Skip to content

🐛CI: Fix timeout value in CI e2e system test #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2025
Merged

🐛CI: Fix timeout value in CI e2e system test #7896

merged 4 commits into from
Jun 13, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jun 13, 2025

What do these changes do?

In Jest befereAll functions have a timeout that is set to 40s but we wait 60s in the function. so the timeout is set to 2 minutes.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jun 13, 2025
@sanderegg sanderegg requested a review from Copilot June 13, 2025 12:04
@sanderegg sanderegg self-assigned this Jun 13, 2025
@sanderegg sanderegg added e2e Bugs found by or related to the end-2-end testing 🤖-automerge marks PR as ready to be merged for Mergify labels Jun 13, 2025
@sanderegg
Copy link
Member Author

sanderegg commented Jun 13, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025 •
edited
Loading

queue

🛑 This queue command has been cancelled by a dequeue command

This comment was marked as outdated.

Sign in to view

@sanderegg sanderegg requested a review from Copilot June 13, 2025 12:05

This comment was marked as outdated.

Sign in to view

bisgaard-itis
bisgaard-itis approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg force-pushed the increase-e2e-timeout2 branch from 21b41f4 to 4ef5dfb Compare June 13, 2025 12:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 13, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sanderegg sanderegg requested a review from Copilot June 13, 2025 12:57
Copilot AI reviewed Jun 13, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the CI e2e system tests where the timeout was misconfigured. The change updates the timeout value in the Jest configuration from 40,000ms to 120,000ms.

  • Correct the timeout so that tests wait for the expected duration.
  • Updates the Jest configuration to match the function's expected wait time.

@sanderegg sanderegg removed the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 13, 2025
@sanderegg
Copy link
Member Author

sanderegg commented Jun 13, 2025

@mergify unqueue

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025

unqueue

✅ The pull request is not waiting to be queued anymore.

@sanderegg
Copy link
Member Author

sanderegg commented Jun 13, 2025

@mergify queue

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 13, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg sanderegg merged commit b4964c1 into ITISFoundation:master Jun 13, 2025
58 checks passed
@sanderegg sanderegg deleted the increase-e2e-timeout2 branch June 13, 2025 13:47
This was referenced Jun 17, 2025
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

Assignees

@sanderegg sanderegg

Labels

🤖-automerge marks PR as ready to be merged for Mergify e2e Bugs found by or related to the end-2-end testing

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

4 participants

@sanderegg @GitHK @pcrespov @bisgaard-itis