-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Require parent info headers when running function #7900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Require parent info headers when running function #7900
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7900 +/- ##
===========================================
- Coverage 86.44% 69.56% -16.88%
===========================================
Files 1845 795 -1050
Lines 71145 36460 -34685
Branches 1220 176 -1044
===========================================
- Hits 61498 25362 -36136
- Misses 9295 11040 +1745
+ Partials 352 58 -294
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering about one thing.
If you want to make it required, I think there is a null UUID which is
00000000-0000-0000-0000-000000000000
import uuid
null_uuid = uuid.UUID(int=0)
# or
str(uuid.UUID(int=0)) # '00000000-0000-0000-0000-000000000000'
services/api-server/src/simcore_service_api_server/api/routes/functions_routes.py
Outdated
Show resolved
Hide resolved
wvangeit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bisgaard-itis
|
@bisgaard-itis I guess this is internal and will be internally handled by calls to Function API? Or do I need to update calls in the frontend? |
@JavierGOrdonnez This will probably have to be added manually. I suggest we sit down and look at it together in the afternoon. We have a mechanism which adds this automatically when submitting solver/study jobs. But it is done in the wrapper |
|
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 9b7bd7c |



What do these changes do?
nullin case there is no parent (e.g. when testing via the swagger view). The way I was able to achieve this was by introduce aNullStringstring. This is a bit similar to theUnSetfrom @pcrespov.Related issue/s
functionapi #7846How to test
Dev-ops