Skip to content

🎨 Reduce the number of acquisition/release of DB connection inside function repository #7904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 17, 2025
Merged

🎨 Reduce the number of acquisition/release of DB connection inside function repository #7904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aa9d645
create 1 connection to run the calls on the DB
sanderegg Jun 16, 2025
3220a24
use from_attributes
sanderegg Jun 16, 2025
c4058fb
use transactions for write functions
sanderegg Jun 17, 2025
89e0459
correct calls
sanderegg Jun 17, 2025
cea4509
typo
sanderegg Jun 17, 2025
f8167fe
sql 2.0
sanderegg Jun 17, 2025
dbabc18
sql 2.0
sanderegg Jun 17, 2025
14d8f85
initial AI stupid
sanderegg Jun 17, 2025
1103188
use async for
sanderegg Jun 17, 2025
c92ce38
changed permissions
sanderegg Jun 17, 2025
eadb6da
sql 2.0
sanderegg Jun 17, 2025
ceb430f
sql 2.0
sanderegg Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/models-library/src/models_library/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,8 @@ class FunctionJobDB(BaseModel):
class_specific_data: FunctionJobClassSpecificData
function_class: FunctionClass

model_config = ConfigDict(from_attributes=True)


class RegisteredFunctionJobDB(FunctionJobDB):
uuid: FunctionJobID
Expand All @@ -242,6 +244,8 @@ class FunctionDB(BaseModel):
default_inputs: FunctionInputs
class_specific_data: FunctionClassSpecificData

model_config = ConfigDict(from_attributes=True)


class RegisteredFunctionDB(FunctionDB):
uuid: FunctionID
Expand All @@ -252,6 +256,8 @@ class FunctionJobCollectionDB(BaseModel):
title: str = ""
description: str = ""

model_config = ConfigDict(from_attributes=True)


class RegisteredFunctionJobCollectionDB(FunctionJobCollectionDB):
uuid: FunctionJobCollectionID
Expand Down
9 changes: 8 additions & 1 deletion services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
FunctionJobCollectionReadAccessDeniedError,
FunctionJobCollectionsReadApiAccessDeniedError,
FunctionJobCollectionsWriteApiAccessDeniedError,
FunctionJobCollectionWriteAccessDeniedError,
FunctionJobIDNotFoundError,
FunctionJobReadAccessDeniedError,
FunctionJobsReadApiAccessDeniedError,
Expand Down Expand Up @@ -283,6 +284,7 @@ async def delete_function_job(
reraise_if_error_type=(
FunctionJobCollectionIDNotFoundError,
FunctionJobCollectionReadAccessDeniedError,
FunctionJobCollectionWriteAccessDeniedError,
FunctionJobCollectionsWriteApiAccessDeniedError,
)
)
Expand All @@ -305,6 +307,7 @@ async def delete_function_job_collection(
reraise_if_error_type=(
FunctionIDNotFoundError,
FunctionReadAccessDeniedError,
FunctionWriteAccessDeniedError,
)
)
async def update_function_title(
Expand All @@ -325,7 +328,11 @@ async def update_function_title(


@router.expose(
reraise_if_error_type=(FunctionIDNotFoundError, FunctionReadAccessDeniedError)
reraise_if_error_type=(
FunctionIDNotFoundError,
FunctionReadAccessDeniedError,
FunctionWriteAccessDeniedError,
)
)
async def update_function_description(
app: web.Application,
Expand Down
Loading
Loading