Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jun 16, 2025

What do these changes do?

  • 🐛 Fix incorrect setup of IN_DEBT transaction state

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 added this to the Engage milestone Jun 16, 2025
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 16, 2025
@matusdrobuliak66 matusdrobuliak66 added the bug buggy, it does not work as expected label Jun 16, 2025
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (9b7bd7c) to head (838287f).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9b7bd7c) and HEAD (838287f). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (9b7bd7c) HEAD (838287f)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7908       +/-   ##
===========================================
- Coverage   87.96%   68.12%   -19.85%     
===========================================
  Files        1845      739     -1106     
  Lines       71149    34510    -36639     
  Branches     1220      176     -1044     
===========================================
- Hits        62589    23509    -39080     
- Misses       8208    10943     +2735     
+ Partials      352       58      -294     
Flag Coverage Δ
integrationtests 64.24% <ø> (-0.01%) ⬇️
unittests 89.00% <100.00%> (+2.44%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.98% <ø> (-8.07%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.63% <ø> (-13.47%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker 89.00% <100.00%> (+0.02%) ⬆️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.95% <ø> (-28.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b7bd7c...838287f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 16, 2025 15:28
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) June 16, 2025 15:30
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Nevertheless I would suggest to have a test that check the complete computation so that this not happen again in case of refactoring or code changes.

@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit 1bb8bcf into ITISFoundation:master Jun 17, 2025
143 of 148 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 RUT - wrongly close transaction to IN_DEBT when it should be billed

4 participants