-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fix incorrect setup of IN_DEBT transaction state #7908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix incorrect setup of IN_DEBT transaction state #7908
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7908 +/- ##
===========================================
- Coverage 87.96% 68.12% -19.85%
===========================================
Files 1845 739 -1106
Lines 71149 34510 -36639
Branches 1220 176 -1044
===========================================
- Hits 62589 23509 -39080
- Misses 8208 10943 +2735
+ Partials 352 58 -294
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
services/resource-usage-tracker/tests/unit/with_dbs/test_api_credit_transactions.py
Outdated
Show resolved
Hide resolved
...acker/src/simcore_service_resource_usage_tracker/services/process_message_running_service.py
Outdated
Show resolved
Hide resolved
...ker/src/simcore_service_resource_usage_tracker/services/modules/db/credit_transactions_db.py
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Nevertheless I would suggest to have a test that check the complete computation so that this not happen again in case of refactoring or code changes.
|
1bb8bcf
into
ITISFoundation:master



What do these changes do?
Related issue/s
IN_DEBTwhen it should be billed #7907How to test
Dev-ops