🐛 [p2e] Update vtk tests #7911
Merged
🐛 [p2e] Update vtk tests #7911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
mrnicegyu11,
pcrespov and
sanderegg
Member
Author
|
@mergify queue |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes and enhances the waitForServices calls across e2e tutorial tests by refactoring them into a multiline signature and ensuring the new waitForConnected flag is documented and applied where needed.
- Refactored
waitForServicesinvocations in multiple portal tutorial scripts to use a multiline argument format. - Introduced or clarified the
waitForConnectedparameter in service waits. - Added a comment in
tutorialBase.jsexplaining the scope ofwaitForConnected.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/tutorials/tutorialBase.js | Adds clarification comment for waitForConnected behavior. |
| tests/e2e/portal/Mattward.js | Reformats waitForServices call to multiline. |
| tests/e2e/portal/Bornstein.js | Reformats waitForServices call to multiline. |
| tests/e2e/portal/BIOS_VNS_Calibrator.js | Reformats waitForServices call and adds explicit flag. |
| tests/e2e/portal/3D_EM.js | Reformats waitForServices call and adds explicit flag. |
| tests/e2e/portal/3D_Anatomical.js | Reformats waitForServices call and adds explicit flag. |
| tests/e2e/portal/2D_Plot.js | Reformats waitForServices call to multiline. |
| tests/e2e/portal-files/VTK_file.js | Reformats waitForServices call and adds explicit flag. |
Comments suppressed due to low confidence (1)
tests/e2e/tutorials/tutorialBase.js:340
- [nitpick] The comment is ambiguous about which services are considered "old dynamic". Please clarify or reference the specific service types or scenarios.
// the waitForConnected only works for old dynamic services
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 522bfc6 |
matusdrobuliak66
approved these changes
Jun 16, 2025
pcrespov
approved these changes
Jun 16, 2025
|
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR updates the p2e tests for the 3d-viewers, they had to be updated because they now run on dynamic services v2.
Related issue/s
How to test
Dev-ops