🐛 [p2e] Update VTK tests #7913
Merged
🐛 [p2e] Update VTK tests #7913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the VTK tests for the paraview service to validate the list of visible entities instead of expecting output files. The key changes are:
- Added a new utility function waitForLabelText in utils.js to check for the presence of text on page elements.
- Updated the 3D_EM test to retrieve an iframe context and verify entity labels within it.
- Updated the 3D_Anatomical test to verify entity labels on the page rather than checking output files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/utils/utils.js | Added waitForLabelText for detecting visible text elements in the DOM. |
| tests/e2e/portal/3D_EM.js | Replaced output file checks with an iframe-based label verification. |
| tests/e2e/portal/3D_Anatomical.js | Replaced output file checks with a page-based label verification. |
Comments suppressed due to low confidence (1)
tests/e2e/portal/3D_Anatomical.js:42
- The file extension 'Bones.e' appears inconsistent with the other entity labels (e.g., 'Vein.vtk' and 'Artery.vtk'); please verify if this is a typo or intentional.
"Bones.e",
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
mrnicegyu11,
pcrespov and
sanderegg
|
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2c40792 |
matusdrobuliak66
approved these changes
Jun 17, 2025
pcrespov
reviewed
Jun 17, 2025
pcrespov
approved these changes
Jun 17, 2025
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The new paraview service doesn't write output files and these were expected in our p2e test. (3D_EM and 3D_anatomical)
This PR replaces those checks with checks in the list of visible entities.
Related issue/s
How to test
Dev-ops