🐛 Fixed director-v2 getting stuck when removing service #7914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7914 +/- ##
==========================================
- Coverage 88.31% 87.91% -0.40%
==========================================
Files 1774 1428 -346
Lines 68970 59345 -9625
Branches 1090 619 -471
==========================================
- Hits 60910 52176 -8734
+ Misses 7740 6960 -780
+ Partials 320 209 -111
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
added 3 commits
June 17, 2025 15:06
GitHK
added
bug
added 3 commits
June 17, 2025 15:14
GitHK
changed the title
giancarloromeo
approved these changes
Jun 17, 2025
sanderegg
approved these changes
Jun 17, 2025
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
Let's not have 3x the same logs please.
packages/service-library/src/servicelib/fastapi/long_running_tasks/_context_manager.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/http_endpoint_responses.py
Outdated
Show resolved
Hide resolved
...-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py
Show resolved
Hide resolved
...-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py
Show resolved
Hide resolved
pcrespov
reviewed
Jun 17, 2025
packages/service-library/src/servicelib/fastapi/long_running_tasks/_context_manager.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/http_endpoint_responses.py
Outdated
Show resolved
Hide resolved
...-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_events_utils.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/long_running_tasks/http_endpoint_responses.py
Show resolved
Hide resolved
added 2 commits
June 18, 2025 10:11
|
pcrespov
approved these changes
Jun 18, 2025
packages/service-library/src/servicelib/long_running_tasks/http_endpoint_responses.py
Show resolved
Hide resolved
Contributor
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b45e2c2 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixed a corner case where the
director-v2could not remove a sidecar due to an unhandled error raised by the long_running_tasks client. Taskattempt_pod_removal_and_data_savingis allowed to raise only under certain situations. Added exception handling for unforeseen errors which addresses the below linked issue.Related issue/s
How to test
Dev-ops