🐛 [Frontend] Reset Password's "Submit" button: Center it and make it fetch button #7921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Reset Password view by replacing the default Button with a FetchButton for the "Submit" action, centering the button and introducing fetch state indication.
- Introduces a private __submitBtn member to store the fetch-enabled submit button.
- Replaces qx.ui.form.Button with osparc.ui.form.FetchButton and applies a "center" property along with a "strong-button" appearance.
- Updates the __submit method to manage fetching state during asynchronous operations.
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/auth/ui/ResetPassView.js:73
- Verify that the 'center: true' property is officially supported by osparc.ui.form.FetchButton and aligns with the component's design contract.
center: true,
services/static-webserver/client/source/class/osparc/auth/ui/ResetPassView.js
Show resolved
Hide resolved
|
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
GitHK
approved these changes
Jun 18, 2025
matusdrobuliak66
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops