🎨 [Frontend] Functions: Show Preview only when requested from MMUX #7948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
odeimaiz
added
t:enhancement
odeimaiz
requested review from
JavierGOrdonnez,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
pcrespov
approved these changes
Jun 23, 2025
matusdrobuliak66
approved these changes
Jun 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the frontend to show only the pipeline preview for functions when requested from the MMUX service, rather than displaying full template details.
- Updated the persistent iframe handler to open a preview-only window for functions.
- Modified study preview to wait for the workbench to be deserialized before rendering.
- Enhanced resource details to treat “function” as a resourceType and restrict its details to the preview tab.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/widget/PersistentIframe.js | Open a function preview window directly and set a static caption. |
| services/static-webserver/client/source/class/osparc/study/StudyPreview.js | Wrap preview widget creation in a deserialization check. |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Add support for a “function” resourceType and limit it to preview. |
services/static-webserver/client/source/class/osparc/widget/PersistentIframe.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/study/StudyPreview.js
Outdated
Show resolved
Hide resolved
…dyPreview.js Co-authored-by: Copilot <[email protected]>
|
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5b16b42 |
matusdrobuliak66
pushed a commit
that referenced
this pull request
Jun 23, 2025
…7948) Co-authored-by: Copilot <[email protected]>
Member
|
@JavierGOrdonnez said this was tested |
|
Yes it was @pcrespov |
JavierGOrdonnez
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
From the MMUX service one can request some extra information about a function. In that situation, osparc would pop up that function's underlaying template information, similar to a template info details. Now, this behaviour needs to be changed to only show the pipeline preview.
Since I can't start the MMUX service, I had to the frontend to make this animation. @JavierGOrdonnez test this once it gets deployed in master.
Related issue/s
How to test
Dev-ops