🐛 [Frontend] Fix: pass welcome credits to backend #7950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug where the frontend was not passing the welcome credits in USD to the backend by ensuring that the proper numeric value (via getValue()) is used.
- In osparc/po/UsersPending.js, a local constant extraCreditsInUsd is introduced to capture and pass the credit value if greater than zero.
- In osparc/po/Invitations.js, the condition now correctly retrieves the numeric value with getValue() before checking and passing it in the payload.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/po/UsersPending.js | Reads credit value into a constant and adds it to the invitation payload if greater than zero. |
| services/static-webserver/client/source/class/osparc/po/Invitations.js | Corrects the conditional check by reading the numeric value from the credit field before passing it to the backend. |
matusdrobuliak66
approved these changes
Jun 23, 2025
pcrespov
approved these changes
Jun 23, 2025
Member
|
@mergify queue |
Contributor
🛑 The pull request has been merged manuallyThe pull request has been merged manually at 4bf443b |
|
giancarloromeo
approved these changes
Jun 23, 2025
matusdrobuliak66
pushed a commit
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The frontend was not passing the
extraCreditsInUsdto the backend in the payload. Here the fix.Related issue/s
How to test
Dev-ops