Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 23, 2025

What do these changes do?

This PR makes the default values used for registering a function editable. It also adds all the input values to the defaultValues.

DefaultInputs

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz added this to the Engage milestone Jun 23, 2025
@odeimaiz odeimaiz self-assigned this Jun 23, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jun 23, 2025
@odeimaiz odeimaiz requested a review from Copilot June 23, 2025 09:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds editable default input values for creating functions and updates the data flow to include these defaults when registering a function.

  • Extend createFunctionData to accept and include defaultInputs
  • Update UI to render numeric inputs as editable text fields and track their values
  • Pass defaultInputs through __createFunction and __registerFunction calls
Comments suppressed due to low confidence (1)

services/static-webserver/client/source/class/osparc/study/CreateFunction.js:198

  • The variable parameterMetadata is not defined in this scope. You need to fetch it (e.g. via osparc.store.Services.getMetadata(parameter["key"], parameter["version"])) before using it in the UI builder.
        if (parameterMetadata && osparc.service.Utils.getParameterType(parameterMetadata) === "number") {

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 23, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Create Functions: Make input values editable 🎨 [Frontend] Create Functions: Make default input values editable Jun 23, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link

@JavierGOrdonnez JavierGOrdonnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks

@odeimaiz odeimaiz merged commit 03bc710 into ITISFoundation:master Jun 23, 2025
59 checks passed
@odeimaiz odeimaiz deleted the feature/function-default-values branch June 23, 2025 10:21
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 23, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow editing of Default Values at the "Create Function" tab

4 participants