-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Create Functions: Make default input values editable #7951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Create Functions: Make default input values editable #7951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds editable default input values for creating functions and updates the data flow to include these defaults when registering a function.
- Extend
createFunctionDatato accept and includedefaultInputs - Update UI to render numeric inputs as editable text fields and track their values
- Pass
defaultInputsthrough__createFunctionand__registerFunctioncalls
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/study/CreateFunction.js:198
- The variable
parameterMetadatais not defined in this scope. You need to fetch it (e.g. viaosparc.store.Services.getMetadata(parameter["key"], parameter["version"])) before using it in the UI builder.
if (parameterMetadata && osparc.service.Utils.getParameterType(parameterMetadata) === "number") {
services/static-webserver/client/source/class/osparc/study/CreateFunction.js
Outdated
Show resolved
Hide resolved
|
wvangeit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
JavierGOrdonnez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks



What do these changes do?
This PR makes the default values used for registering a function editable. It also adds all the input values to the
defaultValues.Related issue/s
How to test
Dev-ops