✨ [Frontend] Conversations: Edit and Delete messages #7954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
odeimaiz
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds the ability for users to edit and delete their own conversation messages via UI controls and new API endpoints.
- Introduces
editMessageanddeleteMessagemethods in the Conversations client - Maps new PUT/DELETE endpoints in the Resources module
- Extends the message UI and AddMessage dialog to support edit and delete flows, refreshing the view on changes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/study/Conversations.js | Added editMessage and deleteMessage client methods |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Defined editMessage (PUT) and deleteMessage (DELETE) endpoints |
| services/static-webserver/client/source/class/osparc/conversation/MessageUI.js | Added menu button, handlers for edit/delete, and fire events to refresh messages |
| services/static-webserver/client/source/class/osparc/conversation/Conversation.js | Propagate studyId to messages and attach listeners for edit/delete events to refetch messages |
| services/static-webserver/client/source/class/osparc/conversation/AddMessage.js | Extended constructor and layout to support editing existing messages and fire messageEdited |
Comments suppressed due to low confidence (3)
services/static-webserver/client/source/class/osparc/conversation/AddMessage.js:39
- [nitpick] The event
commentAddedis inconsistent with the rest of the code that refers to messages; consider renaming it tomessageAddedfor clarity.
"commentAdded": "qx.event.type.Data",
services/static-webserver/client/source/class/osparc/study/Conversations.js:97
- [nitpick] Add JSDoc comments to
editMessageanddeleteMessagemethods explaining parameters and return value for consistency with other client methods.
editMessage: function(studyId, conversationId, messageId, message) {
services/static-webserver/client/source/class/osparc/study/Conversations.js:97
- Consider adding unit or integration tests for the new
editMessageanddeleteMessageclient methods to verify correct parameter mapping and error handling.
editMessage: function(studyId, conversationId, messageId, message) {
services/static-webserver/client/source/class/osparc/conversation/MessageUI.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/conversation/MessageUI.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/conversation/Conversation.js
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Jun 23, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Idea: We can have new type "DELETE_MESSAGE" and you can have updated the type with group_id and the same as we show notification, we can show deleted message :)
sanderegg
approved these changes
Jun 23, 2025
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 904b669 |
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
giancarloromeo
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops