🐛 Use context manager for app server lifecycle in Celery workers #7962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7962 +/- ##
==========================================
- Coverage 87.84% 87.77% -0.08%
==========================================
Files 1849 1423 -426
Lines 71338 59115 -12223
Branches 1252 624 -628
==========================================
- Hits 62668 51887 -10781
+ Misses 8307 7018 -1289
+ Partials 363 210 -153
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
giancarloromeo
commented
Jun 24, 2025
giancarloromeo
requested review from
GitHK,
bisgaard-itis,
matusdrobuliak66 and
sanderegg
bisgaard-itis
approved these changes
Jun 24, 2025
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
👍🏻 thanks for the quick fix
pcrespov
approved these changes
Jun 24, 2025
packages/service-library/src/servicelib/fastapi/celery/app_server.py
Outdated
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Jun 24, 2025
sanderegg
approved these changes
Jun 24, 2025
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
thanks. please check the shutdown timeout comment. thanks!
packages/service-library/src/servicelib/fastapi/celery/app_server.py
Outdated
Show resolved
Hide resolved
1 task
giancarloromeo
changed the title
Contributor
Author
|
While solving the startup issue, a new one related to the shutdown raised (see: #7968). The redesign solves both. |
giancarloromeo
requested review from
bisgaard-itis,
matusdrobuliak66 and
sanderegg
…rloromeo/osparc-simcore into is7957/fix-storage-worker-startup
|
matusdrobuliak66
approved these changes
Jun 25, 2025
bisgaard-itis
approved these changes
Jun 25, 2025
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Great! Thanks a lot for the quick fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR removes timeouts on startup so that App Server initialisation can complete before starting the Celery worker itself.
Compared to the previous version, all slow initialisation procedures (e.g. DB migration) can complete... while the
worker_initwaits for thestartup_completed_eventto finalize the execution.Clean shutdown:
Related issue/s
How to test
Dev-ops