-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Send conversation message notifications to users #7964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Send conversation message notifications to users #7964
Conversation
services/web/server/src/simcore_service_webserver/conversations/_socketio.py
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7964 +/- ##
==========================================
- Coverage 87.83% 84.95% -2.88%
==========================================
Files 1849 692 -1157
Lines 71333 32719 -38614
Branches 1250 176 -1074
==========================================
- Hits 62654 27798 -34856
+ Misses 8317 4863 -3454
+ Partials 362 58 -304
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|



What do these changes do?
This PR fixes the method called to send notifications for conversation messages.
Related issue/s
How to test
Dev-ops