🐛Ensure log/progress queue is restored when websocket connection is restored #7971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
the
a:webserver
sanderegg
requested review from
GitHK,
matusdrobuliak66 and
pcrespov
as code owners
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when a user’s WebSocket connection is restored, their log/progress queue resumes by passing and handling a client_session_id across socket handlers and observers.
- Extended the auth handler to return a
client_session_id. - Updated connect flow to emit
client_session_idwith the user-connected signal. - Added new observers in project slot and adjusted resource-usage handlers to accept
client_session_id.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/web/server/src/simcore_service_webserver/socketio/_handlers.py | Extended auth handler return type and emit arguments |
| services/web/server/src/simcore_service_webserver/resource_usage/_observer.py | Updated observer signatures to accept client_session_id |
| services/web/server/src/simcore_service_webserver/projects/_controller/projects_slot.py | Added user-connected observer that uses client_session_id |
Comments suppressed due to low confidence (3)
services/web/server/src/simcore_service_webserver/socketio/_handlers.py:47
- [nitpick] The docstring for this handler should be updated to mention that a
client_session_idis now returned in addition touser_idandproduct_name.
async def _handler(request: web.Request) -> tuple[UserID, ProductName, str]:
services/web/server/src/simcore_service_webserver/projects/_controller/projects_slot.py:24
- [nitpick] Consider adding a docstring to explain this new observer’s purpose and the meaning of its parameters, especially
client_session_id.
async def _on_user_connected(
services/web/server/src/simcore_service_webserver/socketio/_handlers.py:139
- Add or update unit/integration tests to cover reconnect scenarios and verify that
client_session_idis correctly propagated and used for restoring log/progress queues.
)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7971 +/- ##
==========================================
- Coverage 87.89% 81.23% -6.66%
==========================================
Files 1841 692 -1149
Lines 70996 32726 -38270
Branches 1227 176 -1051
==========================================
- Hits 62401 26585 -35816
+ Misses 8241 6083 -2158
+ Partials 354 58 -296
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
force-pushed
the
bugfix/ensure-rabbitmq-connection-ha
branch
from
84d53cc to
378c79e
Compare
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
sanderegg
force-pushed
the
bugfix/ensure-rabbitmq-connection-ha
branch
from
378c79e to
0572ef4
Compare
pcrespov
approved these changes
Jun 24, 2025
services/web/server/src/simcore_service_webserver/projects/_controller/projects_slot.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_controller/projects_slot.py
Show resolved
Hide resolved
giancarloromeo
approved these changes
Jun 24, 2025
matusdrobuliak66
approved these changes
Jun 25, 2025
sanderegg
force-pushed
the
bugfix/ensure-rabbitmq-connection-ha
branch
from
0572ef4 to
57d30a3
Compare
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 4546aa7 |
|
matusdrobuliak66
pushed a commit
that referenced
this pull request
Jun 26, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR ensures that re-connection of a user to the websocket re-enables the flow of log/progress messages to the frontend.
Related issue/s
How to test
Dev-ops