🎨 [Frontend] Conversation: Listen to WebSocket #7976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
…ancarloromeo/osparc-simcore into feature/listen-to-conv-ws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7976 +/- ##
==========================================
+ Coverage 87.89% 89.68% +1.78%
==========================================
Files 1841 1445 -396
Lines 70996 59892 -11104
Branches 1227 476 -751
==========================================
- Hits 62401 53712 -8689
+ Misses 8241 6059 -2182
+ Partials 354 121 -233
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ancarloromeo/osparc-simcore into feature/listen-to-conv-ws
…ancarloromeo/osparc-simcore into feature/listen-to-conv-ws
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at aa71ed3 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the ResourceDetails pop-up API across the front end to return both the detail widget and its window, updates all callers accordingly, and enhances the Conversations widget to listen and react to WebSocket events (created, updated, deleted).
- Refactor ResourceDetails.popUpInWindow to accept raw data, instantiate internally, and return
{ resourceDetails, window }; update all consumers to destructure and use the new API. - Implement WebSocket event handlers in
osparc.study.Conversationsfor conversation lifecycle events and dynamically add, rename, or remove conversation pages. - Modularize ResourceDetails pages by replacing
__getXPagemethods with__addXPagefunctions and track injected widgets for proper destruction.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/widget/PersistentIframe.js | Use new popUpInWindow API and destructure result |
| services/static-webserver/client/source/class/osparc/ui/window/Window.js | Simplify shorthand property syntax |
| services/static-webserver/client/source/class/osparc/study/Conversations.js | Add studyData property, refactor fetch logic, and register WS events |
| services/static-webserver/client/source/class/osparc/share/ShareePermissions.js | Destructure popUpInWindow result and rename metadata variable |
| services/static-webserver/client/source/class/osparc/notification/NotificationUI.js | Destructure popUpInWindow, update close callback |
| services/static-webserver/client/source/class/osparc/desktop/organizations/TutorialsList.js | Use new popUpInWindow API |
| services/static-webserver/client/source/class/osparc/desktop/organizations/ServicesList.js | Use new popUpInWindow API |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Rewrite popUpInWindow, replace getters with adders, track widgets |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js | Destructure popUpInWindow and update close/open callbacks |
| services/static-webserver/client/source/class/osparc/dashboard/NewPlusMenu.js | Destructure popUpInWindow and update close callback |
| services/static-webserver/client/source/class/osparc/dashboard/CardBase.js | Destructure popUpInWindow and update close/open callbacks |
| services/static-webserver/client/source/class/osparc/conversation/MessageUI.js | Remove legacy padding props |
| services/static-webserver/client/source/class/osparc/conversation/Conversation.js | Rename methods/buttons, extract rename logic |
Comments suppressed due to low confidence (3)
services/static-webserver/client/source/class/osparc/widget/PersistentIframe.js:344
- [nitpick] The local variable name 'window' shadows the global window object, which can be confusing; consider renaming it (e.g., 'popupWindow').
} = osparc.dashboard.ResourceDetails.popUpInWindow(functionData);
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js:942
- [nitpick] Destructuring a variable named 'window' shadows the global window; consider renaming (e.g., 'popupWindow').
const {
services/static-webserver/client/source/class/osparc/dashboard/CardBase.js:1027
- [nitpick] Destructuring a variable named 'window' shadows the global window; consider renaming (e.g., 'popupWindow').
const {
services/static-webserver/client/source/class/osparc/study/Conversations.js
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Jun 26, 2025
Member
|
👀 |
matusdrobuliak66
approved these changes
Jun 27, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In a similar fashion to #7963, this PR listens to the events related to conversations:
created,updatedanddeletedRelated issue/s
How to test
Dev-ops