🐛 Fixes catalog giving access rights to everyone (group 1) to new services 🚨 #7992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7992 +/- ##
==========================================
+ Coverage 87.88% 87.91% +0.03%
==========================================
Files 1853 1846 -7
Lines 71478 71301 -177
Branches 1258 1258
==========================================
- Hits 62819 62686 -133
+ Misses 8295 8251 -44
Partials 364 364
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
changed the title
pcrespov
requested review from
GitHK,
JavierGOrdonnez,
bisgaard-itis,
Copilot,
matusdrobuliak66,
mguidon and
odeimaiz
There was a problem hiding this comment.
Pull Request Overview
This PR restores correct default access rights by ensuring only services without build metadata or built before August 19, 2020 are assigned to the public group. It also enriches the get_service_extras client API and adds tests to cover both scenarios.
- Refactors
_is_old_serviceto first detect missing build details, then compare build dates against the cutoff. - Updates
get_service_extrasto includeservice_build_detailsonly when org labels are present. - Introduces fixtures and unit tests for both director client and utilities, covering services with and without org labels.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/simcore_service_catalog/service/access_rights.py | Rewritten _is_old_service logic and renamed cutoff var. |
| src/simcore_service_catalog/clients/director.py | Conditional inclusion of service_build_details in result. |
| tests/unit/test_utils_service_extras.py | Reformatted import for ServiceExtras. |
| tests/unit/test_clients_director.py | Added service_key_and_version fixture and new tests. |
| tests/unit/conftest.py | Expanded label fixture and added mock_service_extras. |
Comments suppressed due to low confidence (2)
services/catalog/src/simcore_service_catalog/service/access_rights.py:44
- [nitpick] This commented-out placeholder and the unused
client = get_director_client(app)line can be removed to declutter the function and improve readability.
#
services/catalog/src/simcore_service_catalog/clients/director.py:286
- [nitpick] Consider reintroducing a debug log statement here to record the exact build details being included, which can aid troubleshooting and understanding of the compiled result.
result.update({"service_build_details": service_build_details})
JavierGOrdonnez
approved these changes
Jun 26, 2025
|
Cool, thanks! |
odeimaiz
approved these changes
Jun 26, 2025
matusdrobuliak66
approved these changes
Jun 27, 2025
|
Q: But the long term vision is that we are getting rid of group everyone from the DB, is that correct? |
|
@mergify queue |
🟠 Waiting for conditions to match
|
bisgaard-itis
approved these changes
Jun 27, 2025
|
@mergify queue |
🟠 Waiting for conditions to match
|
@matusdrobuliak66 i am not sure about it. The everyone group has its use. What I need to make sure is to understand why the "old" services needed this group. I need to check with @sanderegg |
|
@mergify queue |
🟠 Waiting for conditions to match
|
pcrespov
force-pushed
the
is34/fix-catalog-service-inherit-group-1
branch
from
59912b1 to
660e4c7
Compare
|
pcrespov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes a bug where new services were incorrectly assigned to everyone (
group=1) by default, introduced in #7025.This PR restores the correct behavior:
group=1._OLD_SERVICES_CUTOFF_DATETIME(August 19, 2020).Additional test coverage is included to ensure correctness of the access-rights logic.
Follow up
Related issue/s
How to test
Manual exploratory testing 🚨
services_acces_rightsthat this service in this product does NOT has access rights to everyone 1Dev-ops
None