🐛 [Frontend] Fix template creation texts #7993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the text used when saving a study as a template or sharing it publicly to improve clarity.
- Replaces the conditional multi-line string concatenation with a ternary operator for a more concise implementation.
- Updates the text messages for both public and template modes to be more descriptive.
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/study/SaveAsTemplate.js:52
- [nitpick] Consider verifying if the new single message formatting meets the UI requirements. If a multi-line display was intended, explicit HTML breaks may be needed for clarity.
const introText = this.__makeItPublic ?
…z/osparc-simcore into fix/update-template-helper-texts
odeimaiz
requested review from
capbrown,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
matusdrobuliak66
approved these changes
Jun 26, 2025
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
sanderegg
approved these changes
Jun 27, 2025
Member
Author
|
@mergify queue |
|
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 666016d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
reported by @capbrown
Remove the part that was saying "select users" (the widget was removed) and update texts.
Publish:
Template:
Related issue/s
How to test
Dev-ops