✨ [Frontend] Feature: Localized conversations #7999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
…simcore into feature/localized-chats
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7999 +/- ##
==========================================
- Coverage 87.87% 87.60% -0.28%
==========================================
Files 1853 1448 -405
Lines 71491 59909 -11582
Branches 1258 477 -781
==========================================
- Hits 62821 52481 -10340
+ Misses 8306 7307 -999
+ Partials 364 121 -243
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new “conversation” annotation type to the workbench, allowing users to drop conversation bubbles, open a dedicated conversation panel, and sync with a backend store.
- Adds
drawAnnotationConversationin the SVG wrapper and exposes it in theSvgWidget. - Refactors WorkbenchUI to drive all annotation types (note, rect, text, conversation) through a single
__annotatingstate and consolidates annotation logic. - Introduces a singleton
osparc.store.Conversationsfor all conversation‐related API calls and hooks up conversation events across the UI.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/wrapper/Svg.js | New drawAnnotationConversation + updated updateText to handle groups. |
| services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js | Unified annotation state, added conversation handling and popup logic. |
| services/static-webserver/client/source/class/osparc/store/Conversations.js | Brand-new singleton store for conversation endpoints. |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/wrapper/Svg.js:277
- The new drawAnnotationConversation method has complex layout and truncation logic without accompanying unit or integration tests. Consider adding tests for various title lengths, positioning, and click handler behavior.
drawAnnotationConversation: function(draw, x = 50, y = 50, title = "Conversation") {
services/static-webserver/client/source/class/osparc/store/Conversations.js:156
- The __addToCache and __addPricingUnitToCache methods appear unrelated to conversations (they deal with pricing plans) and likely were copy-pasted here by mistake. Consider removing or moving these methods to their correct store to avoid runtime errors.
__addToCache: function(pricingPlanData) {
services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js
Show resolved
Hide resolved
|
matusdrobuliak66
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR brings the localized?pinned?positioned?
PROJECT_ANNOTATIONtype conversations.Users can now add annotations that reference a conversation. These annotations can be moved around and are bound to their conversation: they can be renamed and when the conversation gets removed the annotations is also removed.
Related issue/s
How to test
Dev-ops