Skip to content

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jun 30, 2025

What do these changes do?

This PR adds a first real and concrete implementation of the Notification service.

Related issue/s

How to test

Dev-ops

@giancarloromeo giancarloromeo added this to the Engage milestone Jun 30, 2025
@giancarloromeo giancarloromeo self-assigned this Jun 30, 2025
@giancarloromeo giancarloromeo changed the title ✨ Add Notification service ✨ Add Notifications service Jun 30, 2025
@codecov
Copy link

codecov bot commented Jun 30, 2025

Codecov Report

❌ Patch coverage is 83.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.06%. Comparing base (35e7048) to head (919dfee).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8011      +/-   ##
==========================================
+ Coverage   88.03%   88.06%   +0.02%     
==========================================
  Files        1919     1860      -59     
  Lines       74341    71804    -2537     
  Branches     1305     1305              
==========================================
- Hits        65449    63235    -2214     
+ Misses       8499     8175     -324     
- Partials      393      394       +1     
Flag Coverage Δ
integrationtests 64.21% <ø> (-0.02%) ⬇️
unittests 86.66% <83.00%> (-0.02%) ⬇️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.37% <100.00%> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.12% <100.00%> (+0.07%) ⬆️
pkg_notifications_library 85.53% <92.30%> (+0.26%) ⬆️
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 72.23% <0.00%> (-0.12%) ⬇️
pkg_settings_library 90.17% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (ø)
agent 93.53% <ø> (ø)
api_server 92.84% <ø> (ø)
autoscaling 95.89% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.15% <ø> (+0.33%) ⬆️
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 90.89% <ø> (-0.03%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.10% <ø> (ø)
efs_guardian 89.62% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.61% <ø> (ø)
resource_usage_tracker 92.13% <ø> (+0.21%) ⬆️
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.11% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35e7048...919dfee. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo changed the title ✨ Add Notifications service ✨ Add Notifications service implementation Jul 2, 2025
@sonarqubecloud
Copy link

@giancarloromeo giancarloromeo modified the milestones: Engage, Voyager Aug 13, 2025
@pcrespov pcrespov self-assigned this Aug 25, 2025
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2025

🧪 CI Insights

Here's what we observed from your CI run for 919dfee.

❌ Failed Jobs

Pipeline Job Health on base branch Retries 🔍 CI Insights 📄 Logs
CI system-tests Healthy 0 View View
unit-tests Healthy 0 View View
PR CI check OAS' are up to date Unknown 0 View View

@sonarqubecloud
Copy link

@pcrespov pcrespov changed the title ✨ Add Notifications service implementation WIP: ✨ Add Notifications service implementation Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

notifications service is failing fast and is rolledback when database version is not (yet) migrated

2 participants