Skip to content

Comments

🎨 Exclude Conversations Annotation UI info when copying projects#8029

Merged
giancarloromeo merged 8 commits intoITISFoundation:masterfrom
giancarloromeo:is8027/exclude-conversations-ui-when-copying-projects
Jul 2, 2025
Merged

🎨 Exclude Conversations Annotation UI info when copying projects#8029
giancarloromeo merged 8 commits intoITISFoundation:masterfrom
giancarloromeo:is8027/exclude-conversations-ui-when-copying-projects

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jul 1, 2025 •
edited
Loading

What do these changes do?

Conversations info (Annotation UI) are excluded when a project is copied/cloned.

Related issue/s

How to test

cd services/web/server
pytest -vv --pdb tests/unit/isolated/test_projects_utils.py

Dev-ops

Nothing to do

@giancarloromeo giancarloromeo self-assigned this Jul 1, 2025
@giancarloromeo giancarloromeo added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Jul 1, 2025
@giancarloromeo giancarloromeo added this to the Engage milestone Jul 1, 2025
@codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (61a124a) to head (e4d43e1).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8029      +/-   ##
==========================================
+ Coverage   87.87%   89.00%   +1.12%     
==========================================
  Files        1853     1448     -405     
  Lines       71491    59913   -11578     
  Branches     1258      477     -781     
==========================================
- Hits        62821    53323    -9498     
+ Misses       8306     6469    -1837     
+ Partials      364      121     -243
Flag Coverage Δ
integrationtests 60.42% <0.00%> (-3.80%) ⬇️
unittests 88.01% <100.00%> (+1.52%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.27% <100.00%> (ø)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (-0.06%) ⬇️
agent 96.29% <ø> (ø)
api_server 92.64% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.21% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (-0.57%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 76.82% <ø> (+0.09%) ⬆️
director_v2 85.38% <ø> (-5.62%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 88.94% <ø> (-0.06%) ⬇️
storage 86.36% <ø> (+0.08%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.65% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a124a...e4d43e1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review July 1, 2025 15:01
odeimaiz
odeimaiz approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very very nice 👌

matusdrobuliak66
matusdrobuliak66 approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

pcrespov
pcrespov approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@giancarloromeo giancarloromeo changed the title 🎨 Exclude Conversations Annotation UI when copying projects 🎨 Exclude Conversations Annotation UI info when copying projects Jul 1, 2025
@giancarloromeo giancarloromeo enabled auto-merge (squash) July 1, 2025 19:11
@giancarloromeo giancarloromeo added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 1, 2025
@giancarloromeo
Copy link
Contributor Author

giancarloromeo commented Jul 1, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

Details
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@giancarloromeo
Merge branch 'master' into is8027/exclude-conversations-ui-when-copyi…
fd9e0ed 
…ng-projects
@giancarloromeo
fix: update openapi-spec
5eca3e3
@giancarloromeo
Merge branch 'is8027/exclude-conversations-ui-when-copying-projects' …
e4d43e1 
…of github.com:giancarloromeo/osparc-simcore into is8027/exclude-conversations-ui-when-copying-projects
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo merged commit ee2070b into ITISFoundation:master Jul 2, 2025
94 of 97 checks passed
@giancarloromeo giancarloromeo deleted the is8027/exclude-conversations-ui-when-copying-projects branch July 2, 2025 07:54
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

Assignees

@giancarloromeo giancarloromeo

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

Don't include Conversations UI data when copying projects

5 participants

@giancarloromeo @pcrespov @odeimaiz @matusdrobuliak66 @bisgaard-itis