Skip to content

🔒️ Fix Conversations permissions checks #8030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025
Merged

🔒️ Fix Conversations permissions checks #8030

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d549ed5
fix: conversations permission checks
giancarloromeo Jul 2, 2025
06ee06a
fix: swap checks
giancarloromeo Jul 2, 2025
eb5473c
Merge branch 'master' into fix-conversations-permissions-checks
giancarloromeo Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions services/web/server/src/simcore_service_webserver/projects/_conversations_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ async def create_project_conversation(
product_name=product_name,
user_id=user_id,
project_id=project_uuid,
permission="read",
permission="write",
)
return await conversations_service.create_conversation(
app,
Expand Down Expand Up @@ -95,7 +95,7 @@ async def update_project_conversation(
product_name=product_name,
user_id=user_id,
project_id=project_uuid,
permission="read",
permission="write",
)
return await conversations_service.update_conversation(
app,
Expand All @@ -118,7 +118,7 @@ async def delete_project_conversation(
product_name=product_name,
user_id=user_id,
project_id=project_uuid,
permission="read",
permission="write",
)
await conversations_service.delete_conversation(
app,
Expand Down Expand Up @@ -170,7 +170,7 @@ async def create_project_conversation_message(
product_name=product_name,
user_id=user_id,
project_id=project_uuid,
permission="read",
permission="write",
)
return await conversations_service.create_message(
app,
Expand Down Expand Up @@ -224,7 +224,7 @@ async def update_project_conversation_message(
product_name=product_name,
user_id=user_id,
project_id=project_uuid,
permission="read",
permission="write",
)
return await conversations_service.update_message(
app,
Expand All @@ -249,7 +249,7 @@ async def delete_project_conversation_message(
product_name=product_name,
user_id=user_id,
project_id=project_uuid,
permission="read",
permission="write",
)
await conversations_service.delete_message(
app,
Expand Down
Loading