🐛 unit-, integration- and system- tests don't fail on cancellation

[giancarloromeo]

What do these changes do?

This PR fixes GitHub actions in order to include the case in which jobs are "cancelled" as a condition to make cumulative unit-tests, integration-tests and system-tests failing.

Related issue/s

How to test

Dev-ops

[Copilot]

Pull Request Overview

This PR refines a module docstring and enhances the CI workflow to treat cancelled jobs as failures.

• Standardizes the module-level docstring in _meta.py
• Expands CI test steps to fail on cancelled jobs in unit, integration, and system tests

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
services/director-v2/src/simcore_service_director_v2/_meta.py	Clean up and consolidate the module docstring
.github/workflows/ci-testing-deploy.yml	Update test-failure conditions to include cancelled results

Comments suppressed due to low confidence (1)

.github/workflows/ci-testing-deploy.yml:1548

• [nitpick] Consider assigning join(needs.*.result, ',') to an environment variable or step output to avoid repeating the expression and improve readability.

        if: ${{ contains(join(needs.*.result, ','), 'failure') || contains(join(needs.*.result, ','), 'cancelled') }}

[pcrespov]

i gues you want to reasign

[giancarloromeo]

i gues you want to reasign

?

[matusdrobuliak66]

Thanks!

[bisgaard-itis]

Very nice! Thanks for catching this 🐟

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.79%. Comparing base (1fd4927) to head (7815a03).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1fd4927) and HEAD (7815a03). Click for more details.

HEAD has 31 uploads less than BASE

Flag	BASE (1fd4927)	HEAD (7815a03)
unittests	32	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #8032       +/-   ##
===========================================
- Coverage   85.96%   69.79%   -16.17%     
===========================================
  Files        1853      696     -1157     
  Lines       71495    32833    -38662     
  Branches     1258      176     -1082     
===========================================
- Hits        61459    22917    -38542     
- Misses       9672     9858      +186     
+ Partials      364       58      -306     

Flag	Coverage Δ
integrationtests	64.20% <ø> (+0.03%)	⬆️
unittests	84.50% <ø> (-0.08%)	⬇️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_celery_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.16% <ø> (-7.83%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	90.99% <ø> (+0.01%)	⬆️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	88.33% <ø> (-1.77%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	58.92% <ø> (-22.14%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd4927...7815a03. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sanderegg]

thanks!

[giancarloromeo]

@Mergifyio queue

[mergify]

queue

🟠 Waiting for conditions to match

• -closed [📌 queue requirement]
• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • label=🤖-automerge
    • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • #approved-reviews-by>=2
    • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by=0
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #review-threads-unresolved=0
    • -conflict
    • -draft
    • base=master
    • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
    • label!=🤖-do-not-merge
    • any of: [🛡 GitHub branch protection]
      • check-skipped = deploy to dockerhub
      • check-neutral = deploy to dockerhub
      • check-success = deploy to dockerhub
    • any of: [🛡 GitHub branch protection]
      • check-success = system-tests
      • check-neutral = system-tests
      • check-skipped = system-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = unit-tests
      • check-neutral = unit-tests
      • check-skipped = unit-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = check OAS' are up to date
      • check-neutral = check OAS' are up to date
      • check-skipped = check OAS' are up to date
    • any of: [🛡 GitHub branch protection]
      • check-success = integration-tests
      • check-neutral = integration-tests
      • check-skipped = integration-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = build-test-images (frontend) / build-test-images
      • check-neutral = build-test-images (frontend) / build-test-images
      • check-skipped = build-test-images (frontend) / build-test-images
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of: [📌 queue -> configuration change requirements]
  • -mergify-configuration-changed
  • check-success = Configuration changed