🐛 [Frontend] Fix: Service's Pricing Plans #8035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes the caching mechanism for service pricing plans by switching from a single-string key to a nested cache keyed by service identifier and version.
- Extract service identifier and version for cache lookup instead of using the full URL string.
- Update cache retrieval to check nested keys, and cache storage to initialize and populate per-service-version entries.
- Adjust logic in
getPricingPlanto align with new nested cache structure.
Comments suppressed due to low confidence (3)
services/static-webserver/client/source/class/osparc/store/Services.js:354
- [nitpick] Using generic names
keyandversioncan cause confusion. Consider renaming toserviceKeyandserviceVersion(orcacheKey/cacheVersion) to clarify their purpose.
const version = serviceUrl["version"];
services/static-webserver/client/source/class/osparc/store/Services.js:372
- There are no existing tests covering the new nested cache behavior. Please add unit tests to verify cache lookups and storage for various service keys and versions.
this.__pricingPlansCached[key][version] = pricingPlansData;
services/static-webserver/client/source/class/osparc/store/Services.js:353
- The
serviceUrlreturned bygetServiceUrlis typically a string, not an object withkeyandversionproperties. Instead, use the originalserviceKeyandserviceVersionparameters to index the cache.
const key = serviceUrl["key"];
mguidon
approved these changes
Jul 2, 2025
Member
mguidon
left a comment
mguidon
left a comment
There was a problem hiding this comment.
Merci. Could that be hot-fixed at some point?
Member
Author
Let's ask @pcrespov what label we should use for hotfix candidates 👍 |
giancarloromeo
approved these changes
Jul 2, 2025
Closed
pcrespov
approved these changes
Jul 2, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
“There are only two hard things in Computer Science: cache invalidation and naming things.”
— Phil Karlton
Member
@matusdrobuliak66 @mguidon list them to the corresponding hotfix issue. In this case I found a one-for-all hotfix issue #8003 |
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
|
matusdrobuliak66
pushed a commit
that referenced
this pull request
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The frontend wasn't caching Service's Pricing Plans correctly. This PR fixes it.
Buggy:
Fixed:
Related issue/s
How to test
Dev-ops