Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jul 3, 2025

What do these changes do?

  • As a preparation for exposing the function job logs in the api-server, here I introduce endpoints for handling async jobs/tasks.
  • I realized that I will have to add an endpoint in director-v2 for the logs themselves. So in order to not polute the PR I prefer to add that endpoint in the director-v2 and use it to expose the task for zipping the logs in the api-server in a separate PR.

Related issue/s

How to test

Dev-ops

@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (44e0e4e) to head (fc20bab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8037      +/-   ##
==========================================
+ Coverage   88.24%   88.28%   +0.04%     
==========================================
  Files        1855     1852       -3     
  Lines       71517    71431      -86     
  Branches     1258     1258              
==========================================
- Hits        63110    63063      -47     
+ Misses       8043     8004      -39     
  Partials      364      364              
Flag Coverage Δ
integrationtests 64.31% <ø> (-0.03%) ⬇️
unittests 86.89% <100.00%> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.15% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.27% <100.00%> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.19% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.37% <ø> (ø)
pkg_settings_library 90.64% <ø> (ø)
pkg_simcore_sdk 85.10% <ø> (+0.05%) ⬆️
agent 96.29% <ø> (ø)
api_server 92.83% <100.00%> (+0.19%) ⬆️
autoscaling 96.03% <ø> (ø)
catalog 92.58% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (-0.57%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 91.01% <ø> (-0.05%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 92.52% <ø> (+0.37%) ⬆️
storage 86.40% <ø> (-0.30%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.62% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e0e4e...fc20bab. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Thx @bisgaard-itis

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! a few questions and comments.

@bisgaard-itis bisgaard-itis requested a review from pcrespov July 4, 2025 12:06
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) July 4, 2025 21:49
@bisgaard-itis bisgaard-itis added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 4, 2025
@bisgaard-itis
Copy link
Contributor Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

@bisgaard-itis bisgaard-itis merged commit 34a9ef0 into ITISFoundation:master Jul 7, 2025
96 of 97 checks passed
@bisgaard-itis bisgaard-itis deleted the 114-expose-function-job-logs-via-api-server branch July 7, 2025 08:30
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service a:celery-library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants