-
Notifications
You must be signed in to change notification settings - Fork 32
♻️Refactor some fixtures and duplications #8042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Refactor some fixtures and duplications #8042
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8042 +/- ##
==========================================
+ Coverage 87.28% 87.95% +0.66%
==========================================
Files 1643 1846 +203
Lines 64771 71305 +6534
Branches 1033 1258 +225
==========================================
+ Hits 56535 62713 +6178
- Misses 7914 8228 +314
- Partials 322 364 +42
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
@mergify queue |
🟠 Waiting for conditions to match
|



What do these changes do?
This pull request refactors and modernizes the database-related test fixtures and helper functions in the
pytest-simcorepackage. Key changes include migrating fixtures and helper functions to use asynchronous patterns, renaming functions for clarity, and updating test cases to align with these changes.Cleanup and removal of redundant code:
create_pipelinefixture fromtests/integration/conftest.pyas it was replaced by the refactored asynchronous version inpytest_simcore.db_entries_mocks. ([packages/simcore-sdk/tests/integration/conftest.pyL244-L271](https://github.com/ITISFoundation/osparc-simcore/pull/8042/files#diff-c335ba77fe385f5c60474088993b1237bf447d1a199596d9bd9b69108f217c86L244-L271))Related issue/s
How to test
Dev-ops