Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 3, 2025

What do these changes do?

This pull request refactors and modernizes the database-related test fixtures and helper functions in the pytest-simcore package. Key changes include migrating fixtures and helper functions to use asynchronous patterns, renaming functions for clarity, and updating test cases to align with these changes.

Cleanup and removal of redundant code:

  • Removed the old create_pipeline fixture from tests/integration/conftest.py as it was replaced by the refactored asynchronous version in pytest_simcore.db_entries_mocks. ([packages/simcore-sdk/tests/integration/conftest.pyL244-L271](https://github.com/ITISFoundation/osparc-simcore/pull/8042/files#diff-c335ba77fe385f5c60474088993b1237bf447d1a199596d9bd9b69108f217c86L244-L271))

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jul 3, 2025
@sanderegg sanderegg self-assigned this Jul 3, 2025
@sanderegg sanderegg added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service labels Jul 3, 2025
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.95%. Comparing base (4090c55) to head (31569fa).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8042      +/-   ##
==========================================
+ Coverage   87.28%   87.95%   +0.66%     
==========================================
  Files        1643     1846     +203     
  Lines       64771    71305    +6534     
  Branches     1033     1258     +225     
==========================================
+ Hits        56535    62713    +6178     
- Misses       7914     8228     +314     
- Partials      322      364      +42     
Flag Coverage Δ
integrationtests 64.29% <ø> (+0.03%) ⬆️
unittests 86.58% <ø> (+0.80%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.15% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.27% <ø> (∅)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.19% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.62% <ø> (ø)
pkg_settings_library 90.64% <ø> (ø)
pkg_simcore_sdk 85.05% <ø> (ø)
agent 96.29% <ø> (ø)
api_server 92.64% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.21% <ø> (ø)
clusters_keeper 99.13% <ø> (∅)
dask_sidecar 92.35% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 91.02% <ø> (+0.02%) ⬆️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.05% <ø> (-0.06%) ⬇️
storage 86.74% <ø> (+0.37%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.74% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4090c55...31569fa. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

@sanderegg sanderegg marked this pull request as ready for review July 3, 2025 16:10
@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 3, 2025
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg sanderegg merged commit 4289fb0 into ITISFoundation:master Jul 4, 2025
97 checks passed
@sanderegg sanderegg deleted the maintenance/refactor-fixtures branch July 4, 2025 05:30
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants