Skip to content

🐛 Concurrent S3 bucket creation attempt #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 7, 2025
Merged

🐛 Concurrent S3 bucket creation attempt #8045

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4aab0c3
fix: concurrent bucket creation
giancarloromeo Jul 4, 2025
60beb71
refactor: extract func
giancarloromeo Jul 4, 2025
5af89e2
log: remove
giancarloromeo Jul 4, 2025
010cc13
Merge branch 'master' into is8043/fix-storage-s3-startup
giancarloromeo Jul 7, 2025
19b1b4a
Merge branch 'master' into is8043/fix-storage-s3-startup
giancarloromeo Jul 7, 2025
f6b5fef
Merge branch 'master' into is8043/fix-storage-s3-startup
mergify[bot] Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions services/storage/src/simcore_service_storage/modules/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from fastapi import FastAPI
from pydantic import TypeAdapter
from servicelib.logging_utils import log_context
from tenacity import wait_exponential
from tenacity.asyncio import AsyncRetrying
from tenacity.before_sleep import before_sleep_log
from tenacity.wait import wait_fixed
Expand Down Expand Up @@ -44,14 +45,29 @@ async def _on_startup() -> None:
assert client # nosec
app.state.s3_client = client

with log_context(_logger, logging.DEBUG, msg="setup.s3_bucket.cleanup_ctx"):
async for attempt in AsyncRetrying(
wait=wait_exponential(min=1), # 1, 2, 4, 8, ...
before_sleep=before_sleep_log(_logger, logging.WARNING),
reraise=True,
):
assert settings.STORAGE_S3 # nosec
await client.create_bucket(
bucket=settings.STORAGE_S3.S3_BUCKET_NAME,
region=TypeAdapter(
BucketLocationConstraintType | Literal["us-east-1"]
).validate_python(settings.STORAGE_S3.S3_REGION),
)
with attempt, log_context(
_logger, logging.DEBUG, msg="setup.s3_bucket.cleanup_ctx"
):
if await client.bucket_exists(
bucket=settings.STORAGE_S3.S3_BUCKET_NAME
):
_logger.info(
"S3 bucket %s exists already, skipping creation",
settings.STORAGE_S3.S3_BUCKET_NAME,
)
break
await client.create_bucket(
bucket=settings.STORAGE_S3.S3_BUCKET_NAME,
region=TypeAdapter(
BucketLocationConstraintType | Literal["us-east-1"]
).validate_python(settings.STORAGE_S3.S3_REGION),
)

async def _on_shutdown() -> None:
if app.state.s3_client:
Expand Down
Loading