-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Enh UX: Number of Active Jobs #8061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…core into enh/changeJobsActive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the Activity Center button to show a simple dot indicator instead of a running-job count, and drives its visibility via initial fetch, socket events, and a periodic timer.
- Replace numeric label with active/inactive dot elements, driven by a new fetch + socket listener + timer
- Add
amIRunningTheStudyhelper inUtils.jsfor filtering socket payloads - Centralize background color into
NavigationBar.BG_COLORand remove legacy job-count events
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/task/TasksButton.js | Swapped hard-coded background color for shared BG_COLOR |
| services/static-webserver/client/source/class/osparc/study/Utils.js | Added amIRunningTheStudy helper to inspect socket projectStateUpdated |
| services/static-webserver/client/source/class/osparc/store/Jobs.js | Removed deprecated changeJobsActive event and its firing logic |
| services/static-webserver/client/source/class/osparc/navigation/NavigationBar.js | Extracted BG_COLOR static and used it instead of inline string |
| services/static-webserver/client/source/class/osparc/jobs/JobsButton.js | Overhauled button: numeric count → dot, fetch logic, socket listener, timer |
| services/static-webserver/client/source/class/osparc/dashboard/CardBase.js | Updated pipeline state comment and included new “PUBLISHED” branch |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/study/Utils.js:401
- Add a JSDoc comment for
amIRunningTheStudyto describe its purpose, parameters, and return value for better maintainability.
amIRunningTheStudy: function(content) {
services/static-webserver/client/source/class/osparc/jobs/JobsButton.js
Outdated
Show resolved
Hide resolved
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 342f7a7 |
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👁️
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we should also have a spinner when stopping a pipeline.
Thanks!
Done 👌 |
|
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



What do these changes do?
This PR improves the UX of the Activity Center Button.
So far we were showing the number of running jobs on the button, but this number would only be updated when the activity center was opened.
In this PR we replace that number with just a dot that will represent whether something or nothing is running.
projectStateUpdatedsocket event, it will check if it's me the one running it (this will eventually change), and if it's the case the dot will be shown (2)Related issue/s
How to test
Dev-ops