Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 7, 2025

What do these changes do?

#8057 broke the tests in notifications service.
This PR fixes them. (AI-generated)

Bonus:

  • fixes a warning accessing a deprecated property access (--> pydantic V3)

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jul 7, 2025
@sanderegg sanderegg self-assigned this Jul 7, 2025
@sanderegg sanderegg requested a review from pcrespov as a code owner July 7, 2025 16:03
@sanderegg sanderegg added bug buggy, it does not work as expected t:maintenance Some planned maintenance work labels Jul 7, 2025
@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (73cf774) to head (e71f02e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8066      +/-   ##
==========================================
+ Coverage   88.19%   90.23%   +2.04%     
==========================================
  Files        1849     1285     -564     
  Lines       71756    53908   -17848     
  Branches     1261      218    -1043     
==========================================
- Hits        63282    48642   -14640     
+ Misses       8111     5196    -2915     
+ Partials      363       70     -293     
Flag Coverage Δ
integrationtests 64.25% <ø> (+0.05%) ⬆️
unittests 88.38% <33.33%> (+1.57%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library 90.39% <33.33%> (-0.25%) ⬇️
pkg_simcore_sdk 84.99% <ø> (-0.06%) ⬇️
agent 96.29% <ø> (ø)
api_server 92.83% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.58% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.35% <ø> (+0.56%) ⬆️
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 91.08% <ø> (+0.06%) ⬆️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.60% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 92.41% <ø> (-0.17%) ⬇️
storage 86.30% <ø> (-0.22%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.55% <ø> (+0.03%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cf774...e71f02e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 7, 2025
@sanderegg sanderegg requested review from GitHK and giancarloromeo July 7, 2025 16:08
@sanderegg
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@sanderegg sanderegg force-pushed the test-dotenv-fails-with-json branch from 7709bb3 to e71f02e Compare July 7, 2025 16:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2025

@sanderegg sanderegg merged commit 3111358 into ITISFoundation:master Jul 7, 2025
89 of 93 checks passed
@sanderegg sanderegg deleted the test-dotenv-fails-with-json branch July 7, 2025 16:22
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify bug buggy, it does not work as expected t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants