🐛 Handles socketio exception on disconnect and fixes double logging of monitoring middleware

[pcrespov]

What do these changes do?

Following up https://github.com/ITISFoundation/private-issues/issues/212, we monitored issues in the logs and here we provides some fixes

1. socketio._handlers.disconnect: Unhandled exception on disconnect handled for socketio. Here session was already cleared before
   
2. monitoring middleware duplicates every log since it the errors_middleware already handles them. Removing logs from it e.g.
   
3. aiohttp.web_exceptions.HTTPCreated: Created logged error is already resolved in 🐛♻️ webserver error handling: Fix incorrect error logging for web.HTTPCreated; cleanup success response handling #7952

Related issue/s

in place

How to test

Dev-ops

None

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (0480725) to head (5864be1).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8067      +/-   ##
==========================================
- Coverage   88.30%   88.21%   -0.10%     
==========================================
  Files        1856     1435     -421     
  Lines       71790    59590   -12200     
  Branches     1262      626     -636     
==========================================
- Hits        63394    52565   -10829     
+ Misses       8031     6816    -1215     
+ Partials      365      209     -156     

Flag	Coverage Δ
integrationtests	64.22% <64.70%> (-0.02%)	⬇️
unittests	86.54% <60.00%> (-0.37%)	⬇️

Components	Coverage Δ
pkg_aws_library	∅ <ø> (∅)
pkg_celery_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	71.37% <33.33%> (+0.12%)	⬆️
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	85.05% <ø> (ø)
agent	96.29% <ø> (ø)
api_server	92.83% <ø> (ø)
autoscaling	95.88% <ø> (ø)
catalog	92.58% <ø> (ø)
clusters_keeper	99.13% <ø> (ø)
dask_sidecar	91.79% <ø> (-0.57%)	⬇️
datcore_adapter	97.94% <ø> (ø)
director	76.77% <ø> (ø)
director_v2	91.01% <ø> (-0.02%)	⬇️
dynamic_scheduler	96.69% <ø> (ø)
dynamic_sidecar	90.09% <ø> (ø)
efs_guardian	89.65% <ø> (ø)
invitations	93.60% <ø> (ø)
payments	92.57% <ø> (ø)
resource_usage_tracker	92.15% <ø> (-0.43%)	⬇️
storage	86.64% <ø> (+0.04%)	⬆️
webclient	∅ <ø> (∅)
webserver	88.60% <64.70%> (-0.08%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0480725...5864be1. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pcrespov]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #review-threads-unresolved=0
    • any of: [🛡 GitHub branch protection]
      • check-neutral = deploy to dockerhub
      • check-skipped = deploy to dockerhub
      • check-success = deploy to dockerhub
    • any of: [🛡 GitHub branch protection]
      • check-neutral = system-tests
      • check-skipped = system-tests
      • check-success = system-tests
    • any of: [🛡 GitHub branch protection]
      • check-neutral = unit-tests
      • check-skipped = unit-tests
      • check-success = unit-tests
    • any of: [🛡 GitHub branch protection]
      • check-neutral = integration-tests
      • check-skipped = integration-tests
      • check-success = integration-tests

[sanderegg]

thanks!

[giancarloromeo]

🙆‍♂️

[matusdrobuliak66]

Thanks

[mergify]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #8067 has been dequeued. The pull request rule doesn't match anymore.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

[GitHK]

Thanks, just a few questions

[pcrespov]

@mergify queue

[mergify]

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • any of: [🛡 GitHub branch protection]
      • check-neutral = system-tests
      • check-skipped = system-tests
      • check-success = system-tests

[mergify]

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud