Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 8, 2025

What do these changes do?

In this PR the UI of the Review Users section in the PO Center was improved, as well as the Services Updates in the Project Card, by reusing the enhanced Chip.

Bonus:

  • Service cards and Project cards share the same code for displaying their Overview section.

Review Users:
image

Services Updates:
image

Overviews:
Overviews

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Jul 8, 2025
@odeimaiz odeimaiz added this to the Engage milestone Jul 8, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Jul 8, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Aesthetics: Use Chip in PO's Review Users 🎨 [Frontend] Aesthetics: Use Chip in PO's Review Users and Update Services Jul 8, 2025
@odeimaiz odeimaiz requested a review from Copilot July 8, 2025 09:21
@odeimaiz odeimaiz marked this pull request as ready for review July 8, 2025 09:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors several UI components to use the new Chip widget for status and version indicators, replacing manual color and label management.

  • Introduces a statusColor property in Chip to auto-style based on predefined statuses.
  • Updates service and PO UIs to use Chip instead of raw labels or images for status display.
  • Consolidates version coloring logic into a reusable paintChip method and updates study/service info layouts.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
services/static-webserver/client/source/class/osparc/ui/basic/Chip.js Adds statusColor property and styling logic to Chip.
services/static-webserver/client/source/class/osparc/service/StatusUI.js Switches deprecated/retired chips to use statusColor.
services/static-webserver/client/source/class/osparc/po/UsersPending.js Replaces status images with Chip and applies statusColor.
services/static-webserver/client/source/class/osparc/metadata/ServicesInStudyUpdate.js Replaces version labels with Chip and uses paintChip.
services/static-webserver/client/source/class/osparc/info/Utils.js Adds infoElementsToLayout helper for reactive info grids.
services/static-webserver/client/source/class/osparc/info/StudyUtils.js Renames createDescriptionMD to createDescription.
services/static-webserver/client/source/class/osparc/info/StudyMedium.js Uses createDescription instead of createDescriptionMD.
services/static-webserver/client/source/class/osparc/info/StudyLarge.js Uses new infoElementsToLayout and updated description helper.
services/static-webserver/client/source/class/osparc/info/ServiceUtils.js Returns a scroll container directly in createDescription.
services/static-webserver/client/source/class/osparc/info/ServiceLarge.js Rebuilds layout to use infoElementsToLayout, streamlines description.
services/static-webserver/client/source/class/osparc/info/MergedLarge.js Updates description creation to use createDescription.
Comments suppressed due to low confidence (2)

services/static-webserver/client/source/class/osparc/info/Utils.js:45

  • Add unit tests for this new infoElementsToLayout helper, verifying it correctly lays out various infoElements inputs in both study and service modes.
    infoElementsToLayout: function(infoElements, isStudy = true) {

services/static-webserver/client/source/class/osparc/info/Utils.js:45

  • Provide a JSDoc or comment describing the expected structure of infoElements and the behavior of this function for future maintainability.
    infoElementsToLayout: function(infoElements, isStudy = true) {

@odeimaiz odeimaiz changed the title 🎨 [Frontend] Aesthetics: Use Chip in PO's Review Users and Update Services 🎨 [Frontend] Aesthetics: Use Chip in PO's Review Users and Services Updates Jul 8, 2025
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov
Copy link
Member

pcrespov commented Jul 8, 2025

@odeimaiz did you read my mind? I was sketching yesterday an issue for this :-)

Consider (2) as well (for sorting/search i can give you options int he backend)
image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 8, 2025

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 8, 2025
@odeimaiz
Copy link
Member Author

odeimaiz commented Jul 8, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d0874a0

@mergify mergify bot merged commit d0874a0 into ITISFoundation:master Jul 8, 2025
110 of 113 checks passed
@odeimaiz odeimaiz deleted the enh/aesthetics branch July 8, 2025 10:42
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants