-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Aesthetics: Use Chip in PO's Review Users and Services Updates
#8069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Chip in PO's Review UsersChip in PO's Review Users and Update Services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors several UI components to use the new Chip widget for status and version indicators, replacing manual color and label management.
- Introduces a
statusColorproperty inChipto auto-style based on predefined statuses. - Updates service and PO UIs to use
Chipinstead of raw labels or images for status display. - Consolidates version coloring logic into a reusable
paintChipmethod and updates study/service info layouts.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/ui/basic/Chip.js | Adds statusColor property and styling logic to Chip. |
| services/static-webserver/client/source/class/osparc/service/StatusUI.js | Switches deprecated/retired chips to use statusColor. |
| services/static-webserver/client/source/class/osparc/po/UsersPending.js | Replaces status images with Chip and applies statusColor. |
| services/static-webserver/client/source/class/osparc/metadata/ServicesInStudyUpdate.js | Replaces version labels with Chip and uses paintChip. |
| services/static-webserver/client/source/class/osparc/info/Utils.js | Adds infoElementsToLayout helper for reactive info grids. |
| services/static-webserver/client/source/class/osparc/info/StudyUtils.js | Renames createDescriptionMD to createDescription. |
| services/static-webserver/client/source/class/osparc/info/StudyMedium.js | Uses createDescription instead of createDescriptionMD. |
| services/static-webserver/client/source/class/osparc/info/StudyLarge.js | Uses new infoElementsToLayout and updated description helper. |
| services/static-webserver/client/source/class/osparc/info/ServiceUtils.js | Returns a scroll container directly in createDescription. |
| services/static-webserver/client/source/class/osparc/info/ServiceLarge.js | Rebuilds layout to use infoElementsToLayout, streamlines description. |
| services/static-webserver/client/source/class/osparc/info/MergedLarge.js | Updates description creation to use createDescription. |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/info/Utils.js:45
- Add unit tests for this new
infoElementsToLayouthelper, verifying it correctly lays out variousinfoElementsinputs in both study and service modes.
infoElementsToLayout: function(infoElements, isStudy = true) {
services/static-webserver/client/source/class/osparc/info/Utils.js:45
- Provide a JSDoc or comment describing the expected structure of
infoElementsand the behavior of this function for future maintainability.
infoElementsToLayout: function(infoElements, isStudy = true) {
Chip in PO's Review Users and Update ServicesChip in PO's Review Users and Services Updates
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@odeimaiz did you read my mind? I was sketching yesterday an issue for this :-) Consider (2) as well (for sorting/search i can give you options int he backend) |
|
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d0874a0 |




What do these changes do?
In this PR the UI of the
Review Userssection in thePO Centerwas improved, as well as theServices Updatesin the Project Card, by reusing the enhanced Chip.Bonus:
Overviewsection.Review Users:

Services Updates:

Overviews:

Related issue/s
How to test
Dev-ops