-
Notifications
You must be signed in to change notification settings - Fork 32
♻️ webserver: Extract Pre-Registration Logic from login Domain into login_accounts
#8080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ webserver: Extract Pre-Registration Logic from login Domain into login_accounts
#8080
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8080 +/- ##
==========================================
+ Coverage 87.74% 88.30% +0.56%
==========================================
Files 1856 1864 +8
Lines 71791 71819 +28
Branches 1261 1261
==========================================
+ Hits 62993 63420 +427
+ Misses 8434 8036 -398
+ Partials 364 363 -1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
c7a6255 to
b14b985
Compare
login_accounts
GitHK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
services/web/server/src/simcore_service_webserver/login_accounts/_controller_rest.py
Show resolved
Hide resolved
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
fe543b7 to
1f658a2
Compare
|
@mergify queue |
🟠 Waiting for conditions to match
|
|



What do these changes do?
This PR initiates a structural refactoring of the
logindomain, which has grown too large and conceptually overloaded. The goal is to improve separation of concerns while maintaining compatibility with the existing structure during the transition.Key Changes:
login_accounts. This marks the beginning of a broader migration of account management logic (including registration and deletion) out of theloginfolder.asyncpg, etc.).logindomain, schemas have been decoupled from REST handlers to improve modularity and clarity.web_utilsThis lays the groundwork for a cleaner architecture around account lifecycle operations while keeping the system functional during the migration.
Related issue/s
How to test
Dev-ops
None