🎨 [Frontend] Check new UI version after logging in #8084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
odeimaiz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the new-version tracker after login and refines the frontend notification logic, while also extending the maintenance warning lead time.
- Uncomments and activates
NewUITrackerinMainPage.js - Adjusts
NewUITrackerto use a simpler flash message (removing the explicit reload button) - Updates
MaintenanceTrackerto warn users 4 days before maintenance instead of 48 hours
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/desktop/MainPage.js | Restores startup of the new-version UI tracker |
| services/static-webserver/client/source/class/osparc/NewUITracker.js | Simplifies flash message, removes widget-based button, and refactors interval callback |
| services/static-webserver/client/source/class/osparc/MaintenanceTracker.js | Changes advance warning interval from 48h to 4 days |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/NewUITracker.js:29
- New version detection logic has been updated but there are no tests covering the success or failure paths. Consider adding unit or integration tests for
NewUITrackerbehaviour when a new release is available and when the check fails.
startTracker: function() {
services/static-webserver/client/source/class/osparc/NewUITracker.js
Outdated
Show resolved
Hide resolved
…ker.js Co-authored-by: Copilot <[email protected]>
odeimaiz
requested review from
GitHK,
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Member
Author
|
@mergify queue |
|
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1f2125c |
matusdrobuliak66
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Now that we are confident that the hard reload is not needed - the frontend makes sure to fetch the new version available, if any - there was another corner case: users get automictically logged out because of maintenance, but if they wouldn't reload the page after maintenance, they would stay with the old frontend.
This PR checks if a new frontend is available after logging in and if it's the case, it shows a Flash Message suggesting the user to reload the page.
Bonus:
Related issue/s
How to test
Dev-ops