-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Adds realtime domain in web-server and WEBSERVER_REALTIME_COLLABORATION Dev Feature Toggle to Settings
#8120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Adds realtime domain in web-server and WEBSERVER_REALTIME_COLLABORATION Dev Feature Toggle to Settings
#8120
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8120 +/- ##
==========================================
- Coverage 88.22% 88.20% -0.02%
==========================================
Files 1881 1883 +2
Lines 72386 72411 +25
Branches 1272 1272
==========================================
+ Hits 63859 63873 +14
- Misses 8153 8163 +10
- Partials 374 375 +1
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
realtime domain in web-server and WEBSERVER_REALTIME_COLLABORATION Dev Feature Toggle to Settings
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So unless there is a follow up PR, RTC can only be enabled if dev_features are also enabled, right? Why not decoupling it?
@odeimaiz Why do you mean decoupling? They are already two different env vars. The idea is that by having |
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. My only comment would be to call this folder collaboration instead of realtime. as the former is more descriptive than the latter. but that is a minor.
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant decoupling the WEBSERVER_REALTIME_COLLABORATION from WEBSERVER_DEV_FEATURES_ENABLED...
So there will eventually be another PR 👍
b07ca03 to
0a7434e
Compare
|
mrnicegyu11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super thx that works



What do these changes do?
Introduced new
WEBSERVER_REALTIME_COLLABORATIONin application's settings and corresponding setup function. NOTE: This field is marked as dev-feature, i.e. will be implicitly disabled ifWEBSERVER_DEV_FEATURES_ENABLED=0.Some details
{ "WEBSERVER_REALTIME_COLLABORATION": { "anyOf": [ { "properties": { "RTC_MAX_NUMBER_OF_USERS": { "description": "Maximum number of users allowed in a real-time collaboration session", "exclusiveMinimum": 0, "title": "Rtc Max Number Of Users", "type": "integer" } }, "required": [ "RTC_MAX_NUMBER_OF_USERS" ], "title": "RealTimeCollaborationSettings", "type": "object" }, { "type": "null" } ], "auto_default_from_env": true, "description": "Enables real-time collaboration features", "x-dev-feature": true } }Related issue/s
isSimultaneousAccessEnabled#8100How to test
@odeimaiz this is how you can determine
.isSimultaneousAccessEnabled()using the response from staticsHere envfile examples
1. enabled and limited to 3 users
2. implicitly disabled (dev-feature)
3. Explicitly disabled
Dev-ops