Skip to content

♻️Fix docker build warnings #8122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2025
Merged

♻️Fix docker build warnings #8122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b38688
fix deprecations
sanderegg Jul 17, 2025
8055b78
fixed warnings
sanderegg Jul 17, 2025
a7cd9ee
removed sensitive data
sanderegg Jul 17, 2025
147c66d
Merge branch 'master' into maintenance/fix-docker-warnings
mergify[bot] Jul 17, 2025
2fb2704
Merge branch 'master' into maintenance/fix-docker-warnings
mergify[bot] Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/postgres-database/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,5 @@ COPY entrypoint.bash /home/entrypoint.bash

RUN chmod +x /home/entrypoint.bash

ENV POSTGRES_USER=scu \
POSTGRES_PASSWORD=adminadmin \
POSTGRES_HOST=postgres \
POSTGRES_PORT=5432 \
POSTGRES_DB=simcoredb

ENTRYPOINT [ "/bin/bash", "/home/entrypoint.bash" ]
CMD [ "sc-pg", "upgrade" ]
2 changes: 1 addition & 1 deletion services/dask-sidecar/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ ARG PYTHON_VERSION="3.11.9"
ARG UV_VERSION="0.7"
FROM ghcr.io/astral-sh/uv:${UV_VERSION} AS uv_build
# we docker image is built based on debian
FROM --platform=${TARGETPLATFORM} python:${PYTHON_VERSION}-slim-bookworm AS base
FROM python:${PYTHON_VERSION}-slim-bookworm AS base
ARG TARGETPLATFORM
ARG BUILDPLATFORM
RUN echo "I am running on $BUILDPLATFORM, building for $TARGETPLATFORM" > /log
Expand Down
9 changes: 1 addition & 8 deletions services/migration/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,7 @@ FROM base AS production

ENV PYTHONOPTIMIZE=TRUE

# testing defaults
ENV POSTGRES_USER=scu \
POSTGRES_PASSWORD=adminadmin \
POSTGRES_HOST=postgres \
POSTGRES_PORT=5432 \
POSTGRES_DB=simcoredb \
SC_DONE_MARK_FILE=migration.done

ENV SC_DONE_MARK_FILE=migration.done

WORKDIR /home/scu

Expand Down
4 changes: 2 additions & 2 deletions services/static-webserver/client/tools/qooxdoo-kit/builder/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ FROM server-base AS production
COPY --from=build-client \
--chown=${SC_USER_NAME}:${SC_USER_NAME} \
/project/build-output "/static-content"
ENV SC_BUILD_TARGET production
ENV SC_BUILD_TARGET=production

FROM server-base AS development
ENV SC_BUILD_TARGET development
ENV SC_BUILD_TARGET=development
6 changes: 3 additions & 3 deletions services/storage/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ ENV PYTHONDONTWRITEBYTECODE=1 \
ENV PATH="${VIRTUAL_ENV}/bin:$PATH"


ENV SC_BUILD_TARGET base
ENV SC_BOOT_MODE default
ENV SC_BUILD_TARGET=base
ENV SC_BOOT_MODE=default

EXPOSE 8080
# -------------------------- -------------------------------
Expand All @@ -81,7 +81,7 @@ EXPOSE 8080

FROM base AS build

ENV SC_BUILD_TARGET build
ENV SC_BUILD_TARGET=build

RUN --mount=type=cache,target=/var/cache/apt,sharing=private \
set -eux \
Expand Down
6 changes: 3 additions & 3 deletions services/web/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ ENV PATH="${VIRTUAL_ENV}/bin:$PATH"


# TODO: eliminate this variable!
ENV IS_CONTAINER_CONTEXT Yes
ENV IS_CONTAINER_CONTEXT=Yes


EXPOSE 8080
Expand All @@ -93,7 +93,7 @@ EXPOSE 8080

FROM base AS build

ENV SC_BUILD_TARGET build
ENV SC_BUILD_TARGET=build

RUN --mount=type=cache,target=/var/cache/apt,sharing=private \
set -eux \
Expand Down Expand Up @@ -206,7 +206,7 @@ CMD ["services/web/server/docker/boot.sh"]
#
FROM build AS development

ENV SC_BUILD_TARGET development
ENV SC_BUILD_TARGET=development

WORKDIR /devel

Expand Down
Loading