✨Allow multiple user sessions (user+tab) to open the same project #8123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
the
a:webserver
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8123 +/- ##
==========================================
+ Coverage 88.07% 88.08% +0.01%
==========================================
Files 1891 1889 -2
Lines 72775 72800 +25
Branches 1274 1280 +6
==========================================
+ Hits 64094 64127 +33
+ Misses 8303 8293 -10
- Partials 378 380 +2
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
force-pushed
the
i1962/let-multiple-users-open-projects
branch
9 times, most recently
from
7c1e2d4 to
134714b
Compare
sanderegg
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
odeimaiz and
pcrespov
as code owners
pcrespov
approved these changes
Jul 22, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
thx
Careful with the reponse models. I think you got at least one wrong
services/web/server/src/simcore_service_webserver/projects/_controller/_rest_exceptions.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_controller/projects_states_rest.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Jul 23, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Looks great! thanks 💯
3 tasks
GitHK
approved these changes
Jul 23, 2025
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Show resolved
Hide resolved
sanderegg
force-pushed
the
i1962/let-multiple-users-open-projects
branch
from
1ae57ce to
f1f8749
Compare
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 633f3c1 |
|
Member
Author
|
@mergify requeue |
Contributor
☑️ This pull request is already queued |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a rather noisy PR as there is some renaming going on. Here are the highlights of the changes:
lockedfield inside the Project model toshareState(or share_state internally)shareStateis also emitted in the projectStateUpdated event (following Node.js variable nomenclature)ProjectLockedis currently still used internallyWEBSERVER_REALTIME_COLLABORATIONENV variable to thePOST "/{VTAG}/projects/{{project_id}}:open"entrypoint (along withRTC_MAX_NUMBER_OF_USERSENV)ProjectTooManyUserSessionsErroris now raised when there are too many user sessions, thrown as a 409 http codeWEBSERVER_DEV_FEATURES_ENABLEDmust be set to use that feature otherwise the current sharing behavior is kept (with the exception of the group IDs explained above)RTC_MAX_NUMBER_OF_USERSis not stricly the number of users but the number of user-session or active tabs (as a reminder, each combination of a user/tab is equivalent to a user-session at the moment.Bonuses and also noise:
services/director-v2/tests/unit/with_dbs/comp_scheduler/test_manager.pyNext steps
Related issue/s
How to test
Dev-ops