Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 21, 2025

What do these changes do?

This PR includes test cleanup and a minor bug fix:

  • ♻️ Removed unused WEBSERVER_CLUSTERS from tests and .env files
  • 🐛 Fixed minor validation issue on account.phone request field

Related issue/s

How to test

In place

Dev-ops ⚠️

@pcrespov pcrespov added this to the Engage milestone Jul 21, 2025
@pcrespov pcrespov self-assigned this Jul 21, 2025
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jul 21, 2025
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.11%. Comparing base (39342c6) to head (898a39e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8132      +/-   ##
==========================================
+ Coverage   88.08%   88.11%   +0.02%     
==========================================
  Files        1891     1891              
  Lines       72701    72702       +1     
  Branches     1274     1274              
==========================================
+ Hits        64040    64059      +19     
+ Misses       8283     8265      -18     
  Partials      378      378              
Flag Coverage Δ
integrationtests 64.20% <100.00%> (+0.01%) ⬆️
unittests 86.74% <100.00%> (+0.02%) ⬆️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.34% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.15% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 71.48% <ø> (ø)
pkg_settings_library 90.45% <ø> (ø)
pkg_simcore_sdk 85.05% <ø> (ø)
agent 93.81% <ø> (ø)
api_server 93.02% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 91.04% <ø> (+0.02%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.50% <ø> (+0.31%) ⬆️
storage 86.60% <ø> (+0.29%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.25% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39342c6...898a39e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title ♻️ Is8129/unused environs ♻️ Maintenance: Cleanup Unused Env Var and Minor Validation Fix Jul 21, 2025
@pcrespov pcrespov marked this pull request as ready for review July 21, 2025 17:43
@pcrespov
Copy link
Member Author

@mergify queue

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 21, 2025
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 48fadf2 into ITISFoundation:master Jul 22, 2025
96 checks passed
@pcrespov pcrespov deleted the is8129/unused-environs branch July 22, 2025 07:14
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw it too late, looks good thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants