🎨 [Frontend] Functions browser: connect FE to BE #8135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om:giancarloromeo/osparc-simcore into is1905/add-new-fuctions-rest-api-endpoints
matusdrobuliak66
approved these changes
Jul 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR connects the frontend functions browser to the backend by implementing API endpoints and updating the client-side code to use real backend data instead of dummy responses. The changes enable full functionality for managing functions in the UI, including creating, reading, updating, and displaying function details with access rights and thumbnails.
- Removes dummy/mock data from frontend and connects to real backend endpoints
- Adds support for including access rights and thumbnails in function responses
- Updates the function data model and UI components to handle real data structures
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| services/web/server/src/simcore_service_webserver/functions/_controller/_functions_rest.py | Adds helper function to include access rights and thumbnails in project function responses |
| services/static-webserver/client/source/class/osparc/store/Functions.js | Removes dummy response logic and adds patch function endpoint |
| services/static-webserver/client/source/class/osparc/data/model/Function.js | Updates function model with proper properties and backend integration |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Adds function endpoints configuration with pagination support |
| services/static-webserver/client/source/class/osparc/info/FunctionUtils.js | New utility class for creating function UI components |
| services/static-webserver/client/source/class/osparc/info/FunctionLarge.js | Updates function details view to use new utilities and backend integration |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Enhances resource details handling for functions with template data |
| services/static-webserver/client/source/class/osparc/dashboard/ListButtonItem.js | Updates list item display logic for functions |
| services/static-webserver/client/source/class/osparc/dashboard/GridButtonItem.js | Updates grid item display logic for functions |
| services/static-webserver/client/source/class/osparc/dashboard/CardBase.js | Adds function-specific logic for access rights and icons |
| services/static-webserver/client/source/class/osparc/po/UsersPending.js | Improves date handling for pending user requests |
| services/static-webserver/client/source/class/osparc/data/Permissions.js | Removes development-only function permission check |
services/static-webserver/client/source/class/osparc/store/Functions.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/po/UsersPending.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/po/UsersPending.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/po/UsersPending.js
Outdated
Show resolved
Hide resolved
GitHK
approved these changes
Jul 23, 2025
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at ba45277 |
sanderegg
approved these changes
Jul 23, 2025
giancarloromeo
added
🤖-do-not-merge
Contributor
|
Solving an issue when updating a function. |
giancarloromeo
added
🤖-automerge
|
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR connects the Functions Browser to the backend.
PROJECTfunction classes, the frontend also fetches the underlying template so that the preview is build with its workbench.access_rightsandthumbnailinget_functionandupdate_functionresponseBonus:
Related issue/s
How to test
Dev-ops