Skip to content

Conversation

@pcrespov
Copy link
Member

What do these changes do?

Ensures directorv2 assigns forwardauth to wb-auth service instead of the standard webserver for dynamic services.

Related issue/s

How to test

Dev-ops

…erences in dynamic proxy spec and docker-compose
@pcrespov pcrespov self-assigned this Jul 22, 2025
@pcrespov pcrespov added the a:director-v2 issue related with the director-v2 service label Jul 22, 2025
@pcrespov pcrespov added this to the Engage milestone Jul 22, 2025
@pcrespov pcrespov marked this pull request as ready for review July 22, 2025 16:07
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 85.86%. Comparing base (acb9f05) to head (329ac47).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8139      +/-   ##
==========================================
- Coverage   88.06%   85.86%   -2.21%     
==========================================
  Files        1891     1649     -242     
  Lines       72775    65413    -7362     
  Branches     1274      940     -334     
==========================================
- Hits        64091    56166    -7925     
- Misses       8306     8944     +638     
+ Partials      378      303      -75     
Flag Coverage Ξ”
integrationtests 62.66% <100.00%> (-1.53%) ⬇️
unittests 84.37% <66.66%> (-2.32%) ⬇️
Components Coverage Ξ”
pkg_aws_library 93.93% <ΓΈ> (ΓΈ)
pkg_celery_library 87.34% <ΓΈ> (ΓΈ)
pkg_dask_task_models_library 79.62% <ΓΈ> (ΓΈ)
pkg_models_library βˆ… <ΓΈ> (βˆ…)
pkg_notifications_library 85.26% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.02% <ΓΈ> (ΓΈ)
pkg_service_integration 70.19% <ΓΈ> (ΓΈ)
pkg_service_library 71.53% <ΓΈ> (+0.04%) ⬆️
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 85.10% <ΓΈ> (+0.05%) ⬆️
agent 93.81% <ΓΈ> (ΓΈ)
api_server 93.02% <ΓΈ> (ΓΈ)
autoscaling 95.88% <ΓΈ> (ΓΈ)
catalog 92.34% <ΓΈ> (ΓΈ)
clusters_keeper 99.13% <ΓΈ> (ΓΈ)
dask_sidecar 92.37% <ΓΈ> (ΓΈ)
datcore_adapter 97.94% <ΓΈ> (ΓΈ)
director 76.14% <ΓΈ> (ΓΈ)
director_v2 90.40% <100.00%> (-0.72%) ⬇️
dynamic_scheduler 96.27% <ΓΈ> (ΓΈ)
dynamic_sidecar 90.07% <ΓΈ> (ΓΈ)
efs_guardian 89.76% <ΓΈ> (ΓΈ)
invitations 91.44% <ΓΈ> (ΓΈ)
payments 92.60% <ΓΈ> (ΓΈ)
resource_usage_tracker 92.55% <ΓΈ> (+0.53%) ⬆️
storage 86.60% <ΓΈ> (+0.20%) ⬆️
webclient βˆ… <ΓΈ> (βˆ…)
webserver 82.75% <ΓΈ> (-5.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update acb9f05...329ac47. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov enabled auto-merge (squash) July 22, 2025 16:10
@sonarqubecloud
Copy link

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks πŸ‘

@pcrespov pcrespov merged commit a71239a into ITISFoundation:master Jul 23, 2025
60 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants