Store function outputs 🎨 ♻️ #8142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvangeit
added
the
a:webserver
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8142 +/- ##
==========================================
- Coverage 88.10% 87.98% -0.12%
==========================================
Files 1893 1470 -423
Lines 72916 60593 -12323
Branches 1279 631 -648
==========================================
- Hits 64239 53314 -10925
+ Misses 8297 7057 -1240
+ Partials 380 222 -158
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
GitHK
approved these changes
Jul 23, 2025
services/web/server/src/simcore_service_webserver/functions/_functions_repository.py
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/functions/_functions_repository.py
Show resolved
Hide resolved
pcrespov
approved these changes
Jul 23, 2025
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py
Outdated
Show resolved
Hide resolved
sanderegg
approved these changes
Jul 23, 2025
wvangeit
commented
Jul 23, 2025
services/api-server/src/simcore_service_api_server/api/routes/function_jobs_routes.py
Show resolved
Hide resolved
Contributor
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at b8bda32 |
|
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In effort to speed up the functions api a bit, the outputs of function are now stored in the function db, and also the status once it reaches SUCCEEDED/FAILED. This avoids some lookups using the study/comp jobs code.
Small refactoring by splitting tests in different files.
How to test
Fetch the status/outputs of a succeeded/failed jobs. These should now come straight from the function job db (and should be stored there)
Dev-ops
No changes