Skip to content

Conversation

@pcrespov
Copy link
Member

What do these changes do?

  • 🎨 adds default network to wb-auth
  • 🎨 adds tracing config to wb-auth
  • 🐛 Fixes tracing config in all services
    • 🔨 add anchor helper for tracing configs

Here a diff of the output of the former (left) and new (right) compose
image

Related issue/s

How to test

rm .env
make .stack-simcore-production.yml
mv .stack-simcore-production.yml .stack-simcore-production-after.yml
git checkout master
rm .env
make .stack-simcore-production.yml
mv .stack-simcore-production.yml .stack-simcore-production-before.yml
diff .stack-simcore-production-after.yml .stack-simcore-production-before.yml 

Dev-ops

@pcrespov pcrespov added this to the Engage milestone Jul 23, 2025
@pcrespov pcrespov self-assigned this Jul 23, 2025
@pcrespov pcrespov added the a:webserver/auth `wb-auth` app in the webserver image label Jul 23, 2025
@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (c4d6cb2) to head (eef7b5f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8148      +/-   ##
==========================================
+ Coverage   87.52%   88.08%   +0.55%     
==========================================
  Files        1891     1891              
  Lines       72835    72836       +1     
  Branches     1279     1279              
==========================================
+ Hits        63749    64154     +405     
+ Misses       8707     8302     -405     
- Partials      379      380       +1     
Flag Coverage Δ
integrationtests 64.23% <0.00%> (+3.83%) ⬆️
unittests 86.69% <100.00%> (-0.02%) ⬇️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.34% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.11% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 71.48% <ø> (-0.05%) ⬇️
pkg_settings_library 90.45% <ø> (ø)
pkg_simcore_sdk 85.05% <ø> (ø)
agent 93.81% <ø> (ø)
api_server 93.02% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 91.08% <ø> (+5.62%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.07% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.39% <ø> (-0.11%) ⬇️
storage 86.39% <ø> (-0.34%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.15% <100.00%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d6cb2...eef7b5f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title Is8147/wb auth missing details 🎨 wb-auth: Configure tracing and network configs Jul 23, 2025
@pcrespov pcrespov marked this pull request as ready for review July 23, 2025 14:16
@pcrespov pcrespov enabled auto-merge (squash) July 23, 2025 14:16
@pcrespov pcrespov requested a review from giancarloromeo July 23, 2025 14:16
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks!

@pcrespov
Copy link
Member Author

@mergify queue

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 23, 2025
@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2025

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. we still need to ensure this is disabled for all tests.

@pcrespov
Copy link
Member Author

@mergify queue

@pcrespov
Copy link
Member Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2025

requeue

☑️ This pull request is already queued

@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 9fc3907 into ITISFoundation:master Jul 24, 2025
95 of 96 checks passed
@pcrespov pcrespov deleted the is8147/wb-auth-missing-details branch July 24, 2025 07:37
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver/auth `wb-auth` app in the webserver image

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wb-auth: Configure tracing and network configs

5 participants