Skip to content

🐛 Avoids raising exceptions when the target container of a hook is not found #8156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2025
Merged

🐛 Avoids raising exceptions when the target container of a hook is not found #8156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
52a4ed9
fixed issue
Jul 24, 2025
7e1c541
Merge branch 'master' into pr-osparc-fix-before-shutdown-error
GitHK Jul 25, 2025
6755584
refactor
Jul 25, 2025
5f49a01
Merge branch 'pr-osparc-fix-before-shutdown-error' of github.com:GitH…
Jul 25, 2025
e11da94
Merge branch 'master' into pr-osparc-fix-before-shutdown-error
GitHK Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/api/rest/containers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from asyncio import Lock
from typing import Annotated, Any, Final

from aiodocker import DockerError
from common_library.json_serialization import json_loads
from fastapi import APIRouter, Depends, HTTPException
from fastapi import Path as PathParam
Expand Down Expand Up @@ -166,6 +167,7 @@ async def get_containers_activity(
ContainerExecContainerNotFoundError,
ContainerExecCommandFailedError,
ContainerExecTimeoutError,
DockerError,
):
_logger.warning(
"Could not run inactivity command '%s' in container '%s'",
Expand Down
2 changes: 2 additions & 0 deletions ...s/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/long_running_tasks_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from datetime import timedelta
from typing import Final

from aiodocker import DockerError
from models_library.callbacks_mapping import UserServiceCommand
from servicelib.logging_utils import log_context

Expand Down Expand Up @@ -39,6 +40,7 @@ async def run_before_shutdown_actions(
ContainerExecContainerNotFoundError,
ContainerExecCommandFailedError,
ContainerExecTimeoutError,
DockerError,
):
_logger.warning(
"Could not run before_shutdown command %s in container %s",
Expand Down
Loading