Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 25, 2025

What do these changes do?

The new app concept within the services/webserver required adjustments, as the previous approach tightly coupled each app to its Python package (simcore_service_webserver) —historically following a one-package-per-app model.

  • 🐛 Removed the use of the package name as app_name in setup_app_tracing since it is the same to all variants of the simcore_wervice_webserver python package; each app now derives its name from the APP_NAME environment variable which is defined for each service (if not defined, it defaults to the package name as before). This fixes [Bug]: wb-auth traces are missing #8161.
  • 🎨 Adds missing monitoring addons (i.e. Prometheus and custom profiler by @bisgaard-itis)
  • 🎨 Ensured naming consistency with Prometheus by aligning it with the OpenTelemetry configuration in setup_app_tracing.

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_login_auth_app.py

Dev-ops

@pcrespov pcrespov self-assigned this Jul 25, 2025
@pcrespov pcrespov added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:webserver/auth `wb-auth` app in the webserver image labels Jul 25, 2025
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.08%. Comparing base (3ecd9de) to head (ef60e82).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8164      +/-   ##
==========================================
+ Coverage   88.07%   88.08%   +0.01%     
==========================================
  Files        1894     1894              
  Lines       73015    73026      +11     
  Branches     1279     1279              
==========================================
+ Hits        64307    64324      +17     
+ Misses       8328     8322       -6     
  Partials      380      380              
Flag Coverage Δ
integrationtests 64.23% <57.89%> (+0.06%) ⬆️
unittests 86.71% <95.65%> (+<0.01%) ⬆️
Components Coverage Δ
pkg_aws_library 93.93% <ø> (ø)
pkg_celery_library 87.34% <ø> (ø)
pkg_dask_task_models_library 79.62% <ø> (ø)
pkg_models_library 93.12% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.02% <ø> (ø)
pkg_service_integration 70.19% <ø> (ø)
pkg_service_library 71.37% <75.00%> (+0.01%) ⬆️
pkg_settings_library 90.46% <ø> (ø)
pkg_simcore_sdk 85.05% <ø> (ø)
agent 93.81% <ø> (ø)
api_server 93.08% <ø> (ø)
autoscaling 95.88% <ø> (ø)
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.37% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.14% <ø> (ø)
director_v2 91.11% <ø> (+0.13%) ⬆️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.08% <ø> (ø)
efs_guardian 89.76% <ø> (ø)
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.50% <ø> (+0.37%) ⬆️
storage 86.31% <ø> (-0.34%) ⬇️
webclient ∅ <ø> (∅)
webserver 88.18% <100.00%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ecd9de...ef60e82. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title WIP: Is8161/wb auth traces 🐛Fixes wb-auth traces as missing Jul 25, 2025
@pcrespov pcrespov marked this pull request as ready for review July 25, 2025 19:26
@pcrespov pcrespov enabled auto-merge (squash) July 25, 2025 19:26
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonarqubecloud
Copy link

@pcrespov
Copy link
Member Author

@Mergifyio queue

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 27, 2025
@pcrespov pcrespov added this to the Engage milestone Jul 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
      • any of: [🛡 GitHub branch protection]
        • check-success = SonarCloud Code Analysis
        • check-neutral = SonarCloud Code Analysis
        • check-skipped = SonarCloud Code Analysis

@pcrespov pcrespov merged commit f8bc96c into ITISFoundation:master Jul 27, 2025
94 of 96 checks passed
@pcrespov pcrespov deleted the is8161/wb-auth-traces branch July 28, 2025 07:48
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver/auth `wb-auth` app in the webserver image a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: wb-auth traces are missing

3 participants