-
Notifications
You must be signed in to change notification settings - Fork 32
🐛Fixes wb-auth traces as missing #8164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛Fixes wb-auth traces as missing #8164
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8164 +/- ##
==========================================
+ Coverage 88.07% 88.08% +0.01%
==========================================
Files 1894 1894
Lines 73015 73026 +11
Branches 1279 1279
==========================================
+ Hits 64307 64324 +17
+ Misses 8328 8322 -6
Partials 380 380
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
YuryHrytsuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
|
@Mergifyio queue |
🟠 Waiting for conditions to match
|



What do these changes do?
The new
appconcept within theservices/webserverrequired adjustments, as the previous approach tightly coupled each app to its Python package (simcore_service_webserver) —historically following a one-package-per-app model.app_nameinsetup_app_tracingsince it is the same to all variants of thesimcore_wervice_webserverpython package; each app now derives its name from theAPP_NAMEenvironment variable which is defined for each service (if not defined, it defaults to the package name as before). This fixes [Bug]:wb-authtraces are missing #8161.setup_app_tracing.Related issue/s
wb-authtraces are missing #8161How to test
Dev-ops