Skip to content

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Jul 28, 2025

What do these changes do?

Related issue/s

How to test

Dev-ops

@GitHK GitHK self-assigned this Jul 28, 2025
@GitHK GitHK added this to the Engage milestone Jul 28, 2025
@GitHK GitHK added the a:services-library issues on packages/service-libs label Jul 28, 2025
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.94%. Comparing base (d928d88) to head (b8b6f95).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8167      +/-   ##
==========================================
+ Coverage   88.05%   89.94%   +1.89%     
==========================================
  Files        1899     1293     -606     
  Lines       73110    54484   -18626     
  Branches     1279      203    -1076     
==========================================
- Hits        64376    49006   -15370     
+ Misses       8354     5412    -2942     
+ Partials      380       66     -314     
Flag Coverage Δ
integrationtests 64.19% <ø> (+0.02%) ⬆️
unittests 88.10% <83.33%> (+1.42%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library 87.37% <100.00%> (+0.03%) ⬆️
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (-0.06%) ⬇️
agent 93.81% <ø> (ø)
api_server 93.08% <ø> (ø)
autoscaling 95.89% <100.00%> (+<0.01%) ⬆️
catalog 92.34% <ø> (ø)
clusters_keeper 99.13% <100.00%> (+<0.01%) ⬆️
dask_sidecar 91.81% <ø> (-0.57%) ⬇️
datcore_adapter 97.94% <ø> (ø)
director 76.23% <ø> (+0.09%) ⬆️
director_v2 91.02% <ø> (-0.10%) ⬇️
dynamic_scheduler 96.27% <ø> (ø)
dynamic_sidecar 90.08% <ø> (ø)
efs_guardian 89.60% <0.00%> (-0.17%) ⬇️
invitations 91.44% <ø> (ø)
payments 92.60% <ø> (ø)
resource_usage_tracker 92.50% <100.00%> (+<0.01%) ⬆️
storage 86.73% <100.00%> (+0.25%) ⬆️
webclient ∅ <ø> (∅)
webserver 88.05% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d928d88...b8b6f95. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GitHK
Copy link
Contributor Author

GitHK commented Jul 28, 2025

found out the issue, this is already part of #8131

@GitHK GitHK closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:services-library issues on packages/service-libs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant