♻️🐛 Fix: Prevent aiohttp.http_exceptions.LineTooLong and improve diagnostics
#8174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
added
the
a:webserver
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8174 +/- ##
==========================================
- Coverage 89.71% 87.93% -1.79%
==========================================
Files 1709 1476 -233
Lines 66465 60655 -5810
Branches 825 631 -194
==========================================
- Hits 59632 53338 -6294
- Misses 6617 7095 +478
- Partials 216 222 +6
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
changed the title
aiohttp.http_exceptions.LineTooLong and improve diagnostics
pcrespov
requested review from
GitHK,
matusdrobuliak66 and
sanderegg
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors exception handling to prevent aiohttp.http_exceptions.LineTooLong errors by avoiding inappropriate use of the reason field in HTTP status lines. The PR systematically replaces reason fields with details across exception classes and improves error context to prevent malformed HTTP responses.
- Rename exception context fields from
reasontodetailsto prevent leakage into HTTP status lines - Update HTTP exception handling to use
textinstead ofreasonfield - Strengthen error handling around HTTP client interactions with director-v2
Reviewed Changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| exception_handling/_factory.py | Update default exception handler template to use text instead of reason |
| rest_middlewares.py | Fix HTTP status setting to use proper reason parameter |
| director_v2/_client_base.py | Strengthen director-v2 client error handling with better context |
| Multiple error classes | Rename reason field to details in exception message templates |
| login/_controller/rest/auth.py | Replace reason parameter with text in HTTP exceptions |
services/web/server/src/simcore_service_webserver/projects/exceptions.py
Outdated
Show resolved
Hide resolved
matusdrobuliak66
approved these changes
Jul 29, 2025
Collaborator
matusdrobuliak66
left a comment
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Thanks for the effort 👍
GitHK
approved these changes
Jul 29, 2025
…eptions.py Co-authored-by: Copilot <[email protected]>
Member
Author
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to match
|
|
This was referenced Aug 5, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Despite previous attempts to mitigate
aiohttp.http_exceptions.LineTooLongat theweb.HTTPExceptionlevel, this error still appears sporadically in production logs. Unfortunately, current logging lacks the necessary context to trace the root cause.Log analysis from test deployments suggests the issue may originate from exceptions raised by the HTTP client communicating with
director-v2. This PR reinforces that interaction and introduces refactorings to reduce the likelihood of malformed responses triggering the error.Changes:
reasonfield inaiohttp.web.HTTPException(gets used as HTTP status line); usetextinstead.reasonkey to prevent leakage into HTTP status lines.reasontodetailsfor clarity and to prevent misuse.director-v2.Related issue/s
How to test
Dev-ops