-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 dynamic service status is now propagated to the project_id and not the node_id #8175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 dynamic service status is now propagated to the project_id and not the node_id #8175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR changes the notification mechanism for dynamic service status updates from notifying individual users to notifying all users within a project. This enables multiple users in the same project to receive real-time status updates when a node's status changes.
- Changed notification target from
user_idtoproject_idin the status monitoring system - Updated the service tracker API to retrieve project IDs instead of user IDs
- Modified the notifier to emit status changes to project-based socket rooms
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
_deferred_get_status.py |
Updated status notification logic to use project_id instead of user_id |
_api.py |
Renamed function from get_user_id_for_service to get_project_id_for_service and updated return type |
__init__.py |
Updated module exports to reflect the API function name change |
_notifier.py |
Changed notification parameters and socket room targeting from user-based to project-based |
...ces/dynamic-scheduler/src/simcore_service_dynamic_scheduler/services/service_tracker/_api.py
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #8175 +/- ##
===========================================
- Coverage 88.04% 67.79% -20.26%
===========================================
Files 1900 787 -1113
Lines 73074 35092 -37982
Branches 1280 176 -1104
===========================================
- Hits 64336 23789 -40547
- Misses 8358 11245 +2887
+ Partials 380 58 -322
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You may have to fix your CI before adding the pull request to the queue again. |
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
odeimaiz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project_in instead of user_id, thanks!
|



What do these changes do?
Notify project_id instead of node_id when the status of a node changes. Allows for multiple users to view the node's status change.
Related issue/s
How to test
Dev-ops