-
Notifications
You must be signed in to change notification settings - Fork 32
🐛🎨 [Frontend] RTC: UX fixes #8179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements RTC (Real-Time Collaboration) fixes and enhancements for the frontend, focusing on node movement synchronization, state management improvements, and conversation UI enhancements.
- Fix edge updates after node moves from other clients by removing node type filtering
- Improve conversation button with blinking notifications for incoming messages
- Fix template type patching and study state fetching method names
- Remove IN_USE state blocking for RTC-enabled environments
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js | Removes node type filtering for edge updates and simplifies UI element lookup methods |
| services/static-webserver/client/source/class/osparc/workbench/NodeUI.js | Removes getNodeType method and adds nodeMovingStop event emission |
| services/static-webserver/client/source/class/osparc/utils/Utils.js | Refactors button blinking mechanism with improved interval management |
| services/static-webserver/client/source/class/osparc/study/Conversations.js | Adds constants for WebSocket channels and implements button blinking for notifications |
| services/static-webserver/client/source/class/osparc/store/Study.js | Renames getStudyState to fetchStudyState for clarity |
| services/static-webserver/client/source/class/osparc/info/StudyLarge.js | Fixes patchTemplateType call to pass serialized study data |
| services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js | Updates conversation button with blinking functionality |
| services/static-webserver/client/source/class/osparc/desktop/MainPage.js | Updates method calls to use renamed fetchStudyState and fixed patchTemplateType |
| services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js | Removes project locked check for CLOSING state handling |
| services/static-webserver/client/source/class/osparc/dashboard/CardBase.js | Removes IN_USE state filtering for RTC environments |
services/static-webserver/client/source/class/osparc/utils/Utils.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/study/Conversations.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/study/Conversations.js
Show resolved
Hide resolved
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|



What do these changes do?
IN_USEis a valid state, let the backend lock the project (shareState.locked) when we hitRTC_MAX_NUMBER_OF_USERSRelated issue/s
How to test
Dev-ops