Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jul 31, 2025

What do these changes do?

  • Fix: Update edges after node move from clientB
  • Fix: patchTemplateType
  • Fix: IN_USE is a valid state, let the backend lock the project (shareState.locked) when we hit RTC_MAX_NUMBER_OF_USERS
  • Fix: In order to avoid race conditions with Closing and Closed states coming from different channels, after receiving Closing, fetch state 2" later.
  • Enh Conversations: make button blink when there is something coming
  • Enh Conversations: ctrl+enter sends the message
  • Fix: functions listing @wvangeit

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz added this to the Engage milestone Jul 31, 2025
@odeimaiz odeimaiz self-assigned this Jul 31, 2025
@odeimaiz odeimaiz marked this pull request as ready for review July 31, 2025 13:25
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Jul 31, 2025
@odeimaiz odeimaiz requested a review from Copilot July 31, 2025 13:26
@odeimaiz odeimaiz changed the title 🎨🐛 [Frontend] RTC 🎨🐛 [Frontend] RTC: UX fixes Jul 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements RTC (Real-Time Collaboration) fixes and enhancements for the frontend, focusing on node movement synchronization, state management improvements, and conversation UI enhancements.

  • Fix edge updates after node moves from other clients by removing node type filtering
  • Improve conversation button with blinking notifications for incoming messages
  • Fix template type patching and study state fetching method names
  • Remove IN_USE state blocking for RTC-enabled environments

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
services/static-webserver/client/source/class/osparc/workbench/WorkbenchUI.js Removes node type filtering for edge updates and simplifies UI element lookup methods
services/static-webserver/client/source/class/osparc/workbench/NodeUI.js Removes getNodeType method and adds nodeMovingStop event emission
services/static-webserver/client/source/class/osparc/utils/Utils.js Refactors button blinking mechanism with improved interval management
services/static-webserver/client/source/class/osparc/study/Conversations.js Adds constants for WebSocket channels and implements button blinking for notifications
services/static-webserver/client/source/class/osparc/store/Study.js Renames getStudyState to fetchStudyState for clarity
services/static-webserver/client/source/class/osparc/info/StudyLarge.js Fixes patchTemplateType call to pass serialized study data
services/static-webserver/client/source/class/osparc/desktop/WorkbenchView.js Updates conversation button with blinking functionality
services/static-webserver/client/source/class/osparc/desktop/MainPage.js Updates method calls to use renamed fetchStudyState and fixed patchTemplateType
services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js Removes project locked check for CLOSING state handling
services/static-webserver/client/source/class/osparc/dashboard/CardBase.js Removes IN_USE state filtering for RTC environments

@odeimaiz odeimaiz changed the title 🎨🐛 [Frontend] RTC: UX fixes 🐛🎨 [Frontend] RTC: UX fixes Jul 31, 2025
@odeimaiz odeimaiz changed the title 🐛🎨 [Frontend] RTC: UX fixes 🐛🎨 [FE] RTC: UX FXS Jul 31, 2025
@odeimaiz odeimaiz changed the title 🐛🎨 [FE] RTC: UX FXS 🐛🎨 [Frontend] RTC: UX fixes Jul 31, 2025
@odeimaiz odeimaiz requested review from GitHK and giancarloromeo July 31, 2025 13:43
@odeimaiz odeimaiz requested review from pcrespov and sanderegg July 31, 2025 13:43
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sonarqubecloud
Copy link

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

🧪 CI Insights

Here's what we observed from your CI run for a087b57.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on base branch Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@odeimaiz odeimaiz merged commit e2f0683 into ITISFoundation:master Jul 31, 2025
59 checks passed
@odeimaiz odeimaiz deleted the rtc-2 branch July 31, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants