Skip to content

🐛Ensure nodeProgress event is sent to project chat #8180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 31, 2025
Merged

🐛Ensure nodeProgress event is sent to project chat #8180

merged 5 commits into from
Jul 31, 2025

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Jul 31, 2025

What do these changes do?

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Engage milestone Jul 31, 2025
@sanderegg sanderegg self-assigned this Jul 31, 2025
@sanderegg sanderegg added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs 🤖-automerge marks PR as ready to be merged for Mergify labels Jul 31, 2025
@sanderegg sanderegg requested a review from odeimaiz July 31, 2025 12:02
@sanderegg
Copy link
Member Author

sanderegg commented Jul 31, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025 •
edited
Loading

queue

🛑 This queue command has been cancelled by a dequeue command

odeimaiz
odeimaiz approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geil!

pcrespov
pcrespov approved these changes Jul 31, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@codecov
Copy link

codecov bot commented Jul 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.15%. Comparing base (e2f0683) to head (5327ba7).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8180      +/-   ##
==========================================
- Coverage   88.07%   85.15%   -2.92%     
==========================================
  Files        1905      739    -1166     
  Lines       73166    33838   -39328     
  Branches     1280      176    -1104     
==========================================
- Hits        64439    28816   -35623     
+ Misses       8347     4964    -3383     
+ Partials      380       58     -322
Flag Coverage Δ
integrationtests 64.19% <100.00%> (+<0.01%) ⬆️
unittests 87.40% <100.00%> (+0.70%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.16% <ø> (-8.01%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.07% <ø> (-14.03%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 87.31% <ø> (-2.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 88.20% <100.00%> (+0.05%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2f0683...5327ba7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg
Copy link
Member Author

sanderegg commented Jul 31, 2025

@mergify unqueue

@mergify
Copy link
Contributor

mergify bot commented Jul 31, 2025

unqueue

✅ The pull request is not waiting to be queued anymore.

@sanderegg sanderegg removed the 🤖-automerge marks PR as ready to be merged for Mergify label Jul 31, 2025
@sanderegg sanderegg enabled auto-merge (squash) July 31, 2025 12:31
@sanderegg sanderegg force-pushed the bugfix/8178/send-message-to-all-groups branch from d4344c4 to de512bd Compare July 31, 2025 14:44
@sanderegg sanderegg changed the title 🐛Ensure nodeProgress event is sent to all user groups 🐛Ensure nodeProgress event is sent to project chat Jul 31, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 31, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg merged commit a723904 into ITISFoundation:master Jul 31, 2025
94 of 96 checks passed
@sanderegg sanderegg deleted the bugfix/8178/send-message-to-all-groups branch July 31, 2025 16:29
This was referenced Aug 5, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

Assignees

@sanderegg sanderegg

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

RTC: nodeProgress socket event should be sent to the project_id

3 participants

@sanderegg @pcrespov @odeimaiz