🐛 [Frontend] Fix: Search filter's reset button #8182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the extended filter functionality within the frontend dashboard. The main issue was that the reset button in the extended filter wasn't properly communicating with the main search filter, causing the UI to get out of sync when filters were reset.
- Removed debug/test code that was hardcoding values in notifications and jobs buttons
- Fixed the extended filter reset functionality by adding proper event handling between components
- Added null safety checks to prevent errors when filter data is undefined during reset operations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| NotificationsButton.js | Removed hardcoded debug value for unread notifications count |
| JobsButton.js | Removed hardcoded debug value for active job status |
| StudyBrowser.js | Added event listeners and null safety checks for filter reset handling |
| SearchBarFilterExtended.js | Added resetFilter event emission when reset button is tapped |
| SearchBarFilter.js | Refactored reset logic and added event emission for reset button presses |
services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js
Outdated
Show resolved
Hide resolved
…re into fix/etended-filter
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
odeimaiz
changed the title
odeimaiz
added
bug
odeimaiz
changed the title
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
sanderegg
approved these changes
Jul 31, 2025
|
pcrespov
approved these changes
Aug 1, 2025
This was referenced Aug 5, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The reset button of the searchFilter and extendedSearchFilter were buggy, this PR fixes it.
Buggy:
Fixed:
Related issue/s
How to test
Dev-ops