🎨 [Frontend] Enh: admins are also pos
#8185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
admins are also posadmins are also pos
odeimaiz
added
t:enhancement
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the frontend to allow administrators to access the PO (Product Owner) center. The key change is updating the role permission logic so that admin users are treated as having product_owner privileges, enabling them to access PO-specific functionality.
- Expands
isProductOwner()to include admin role alongside product_owner - Reorganizes menu item order for better grouping by permission hierarchy
- Fixes a minor spelling error in an error message
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| osparc/data/Permissions.js | Updated isProductOwner() method to include admin role |
| osparc/navigation/UserMenu.js | Reordered menu items to reflect permission hierarchy (tester, po, admin) |
| osparc/po/UsersPending.js | Fixed spelling error in confirmation message |
services/static-webserver/client/source/class/osparc/data/Permissions.js
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
Konohana0608,
giancarloromeo,
matusdrobuliak66 and
sanderegg
giancarloromeo
approved these changes
Aug 4, 2025
matusdrobuliak66
approved these changes
Aug 4, 2025
GitHK
approved these changes
Aug 4, 2025
This was referenced Aug 5, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR updates the frontend to let
Admins open thePOcenter. Changes in the backend need to follow so that the endpoints are open to the role.Related issue/s
Adminrole #8186How to test
Dev-ops